[GitHub] [spark] LuciferYang commented on a diff in pull request #38132: [SPARK-40677][CONNECT][BUILD] Shade more dependency to be able to run separately

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #38132:
URL: https://github.com/apache/spark/pull/38132#discussion_r989909422


##########
connector/connect/pom.xml:
##########
@@ -271,6 +282,31 @@
               <pattern>io.grpc</pattern>
               <shadedPattern>${spark.shade.packageName}.connect.grpc</shadedPattern>
             </relocation>
+
+            <relocation>
+              <pattern>com.google.android</pattern>

Review Comment:
   @HyukjinKwon Sorry for the late reply
   
   The relocation rule may be incorrect
   
   I think it should be 
   
   ```
   <pattern>android.annotation</pattern>
   <shadedPattern>${spark.shade.packageName}.connect.android.annotation</shadedPattern>
   ```
   
   and unzip the `assembly` jar, the contents are as follows:
   
   ```
   ls
   
   META-INF	android		com		google		grpc		org		spark
   ```
   
   Not all contents are placed in `${spark.shade.packageName}.connect`, which may require further check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org