You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "av8or1 (via GitHub)" <gi...@apache.org> on 2024/01/08 19:34:06 UTC
Re: [I] [C++][FS][Azure] Implement `DeleteFile()` [arrow]
av8or1 commented on issue #38703:
URL: https://github.com/apache/arrow/issues/38703#issuecomment-1881703555
Tom, I have an initial implementation completed. However, I have concerns surrounding testing. Specifically:
1) How have other contributors been testing similar functionality?
2) Is there a scripted process that I can follow to replicate that testing?
3) I took a look at the azurefs_test.cc file and noted the modifications made to provide regression for similar functionality. However I am wondering what all use cases I would need to support for DeleteFile? I am not as familiar with this type of testing, as we do our own in-house stuff, but this seems straightforward enough.
Finally, I implemented this using DeleteIfExists() rather than Delete(), for I saw that the former method was used elsewhere in the Azure work. Any feedback regarding that choice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org