[jira] Resolved: (BUILDR-399) invoke_with_call_chain does not restore call chain correctly

["Alex Boisvert (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BUILDR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved BUILDR-399.
----------------------------------

    Resolution: Fixed

Fixed and added spec.  Thanks for debugging and reporting this!

Sending        CHANGELOG
Sending        lib/buildr/core/application.rb
Sending        spec/core/application_spec.rb
Transmitting file data ...
Committed revision 923476.


> invoke_with_call_chain does not restore call chain correctly
> ------------------------------------------------------------
>
>                 Key: BUILDR-399
>                 URL: https://issues.apache.org/jira/browse/BUILDR-399
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.5
>            Reporter: Pepijn Van Eeckhoudt
>            Priority: Critical
>             Fix For: 1.4
>
>         Attachments: spec.txt
>
>
> invoke_with_call_chain currently does
> begin
>  old_chain, Thread.current[:rake_chain] = Thread.current[:rake_chain], new_chain
>  execute(task_args) if needed?
> ensure
>  Thread.current[:rake_chain] = nil
> end
> The ensure block restores the call chain incorrectly. The call chain should be restored to old_chain rather than nil.
> Attached spec reproduces the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.