You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Feng Zhu (Jira)" <ji...@apache.org> on 2020/04/20 12:37:00 UTC
[jira] [Commented] (CALCITE-3447) Fix equivalents in method
SubstitutionVisitor#go
[ https://issues.apache.org/jira/browse/CALCITE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087667#comment-17087667 ]
Feng Zhu commented on CALCITE-3447:
-----------------------------------
Fixed in [https://github.com/apache/calcite/commit/bf0ca495a4690f9f66374e9e67af8760c09719c7], thanks for your work, [~daimin], [~jinxing6042@126.com]!
> Fix equivalents in method SubstitutionVisitor#go
> ------------------------------------------------
>
> Key: CALCITE-3447
> URL: https://issues.apache.org/jira/browse/CALCITE-3447
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: daimin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> Code segment here depends on `hashcode` and `equals` methods of class `MutableRel`:
> [https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java#L492-L502]
> However the implementations of class `MutableScan` delegates to class `TableScan`, which directly relies on implementations of class `Object`. This leads to a situation that two `MutableScan` on the exactly same table will not be considered as equivalent.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)