You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2025/02/03 18:14:00 UTC

[jira] [Work logged] (ARTEMIS-5139) Remove locking on TypedProperties getters

     [ https://issues.apache.org/jira/browse/ARTEMIS-5139?focusedWorklogId=955272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955272 ]

ASF GitHub Bot logged work on ARTEMIS-5139:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Feb/25 18:13
            Start Date: 03/Feb/25 18:13
    Worklog Time Spent: 10m 
      Work Description: jbertram opened a new pull request, #5486:
URL: https://github.com/apache/activemq-artemis/pull/5486

   Back in 8e40b2d4f4f242271d3dfcda4f9b96d3f94cee1b thread safety was added to TypedProperties by synchronizing all relevant methods. This was simple and effective but suffers from performance issues in read-heavy use-cases.
   
   This commit improves the performance by using a read/write locking mechanism so reads can execute concurrently.
   
   No new tests were added since the original commit added tests to verify thread safety.




Issue Time Tracking
-------------------

            Worklog Id:     (was: 955272)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove locking on TypedProperties getters
> -----------------------------------------
>
>                 Key: ARTEMIS-5139
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5139
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>            Reporter: Josh Byster
>            Priority: Minor
>         Attachments: Screenshot 2024-10-30 at 10.38.54 PM.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We are noticing a performance degradation when switching to Artemis in places where we are sensitive on the millisecond level. We have confirmed that moving to ZGC and having minimal GC pause times cannot explain this spike. Looking at a flight recording, it does appear we are spending a lot of time blocked on TypedProperties getters (see screenshot). It seems like we can probably remove some of the locking here with a concurrent collection or be smarter about it with a ReadWriteLock, given that it appears we have threads competing for read calls.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@activemq.apache.org
For additional commands, e-mail: issues-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact