You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/09/16 01:02:55 UTC
Review Request 25671: Instruct thrift to generate private fields in
java.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25671/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
This more closely matches our encapsulation elsewhere in the codebase, and makes for simpler refactoring in the future.
Diffs
-----
build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
src/main/java/org/apache/aurora/scheduler/base/Jobs.java 7b10cf876d4424fab06113aa3e2989a6bef4d346
src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java bfca1d9776fea1259eb46ae61be08b5c9082d769
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java e3c20cbafffb6f9f614b42fc2379f1239e182161
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fedba15792ff2ecf55922ce5c38b85ada2a9edf4
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java cf9805155f0e17b75db9ef8edd4b805826107868
src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java f100ada567e3a0945af00c78c84f72c86e1bfb99
Diff: https://reviews.apache.org/r/25671/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Bill Farner
Re: Review Request 25671: Instruct thrift to generate private fields
in java.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25671/#review53432
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Sept. 15, 2014, 4:02 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25671/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 4:02 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This more closely matches our encapsulation elsewhere in the codebase, and makes for simpler refactoring in the future.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> src/main/java/org/apache/aurora/scheduler/base/Jobs.java 7b10cf876d4424fab06113aa3e2989a6bef4d346
> src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java bfca1d9776fea1259eb46ae61be08b5c9082d769
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java e3c20cbafffb6f9f614b42fc2379f1239e182161
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fedba15792ff2ecf55922ce5c38b85ada2a9edf4
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java cf9805155f0e17b75db9ef8edd4b805826107868
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java f100ada567e3a0945af00c78c84f72c86e1bfb99
>
> Diff: https://reviews.apache.org/r/25671/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 25671: Instruct thrift to generate private fields
in java.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25671/#review53435
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Sept. 15, 2014, 4:02 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25671/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 4:02 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This more closely matches our encapsulation elsewhere in the codebase, and makes for simpler refactoring in the future.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> src/main/java/org/apache/aurora/scheduler/base/Jobs.java 7b10cf876d4424fab06113aa3e2989a6bef4d346
> src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java bfca1d9776fea1259eb46ae61be08b5c9082d769
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java e3c20cbafffb6f9f614b42fc2379f1239e182161
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fedba15792ff2ecf55922ce5c38b85ada2a9edf4
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java cf9805155f0e17b75db9ef8edd4b805826107868
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java f100ada567e3a0945af00c78c84f72c86e1bfb99
>
> Diff: https://reviews.apache.org/r/25671/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>