You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Ralph Goers (Jira)" <ji...@apache.org> on 2019/09/15 01:54:00 UTC
[jira] [Commented] (LOG4J2-2674) CompositeConfiguration misleading
configuration source
[ https://issues.apache.org/jira/browse/LOG4J2-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929864#comment-16929864 ]
Ralph Goers commented on LOG4J2-2674:
-------------------------------------
I'm afraid I don't understand the problem. From the patch it appears all you are doing is renaming NULL_SOURCE to COMPOSITE_SOURCE.
> CompositeConfiguration misleading configuration source
> ------------------------------------------------------
>
> Key: LOG4J2-2674
> URL: https://issues.apache.org/jira/browse/LOG4J2-2674
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.8.1
> Reporter: Anton Korenkov
> Priority: Trivial
> Labels: pull-request-available
>
> Sometimes we are using CompositeConfiguration in our code. During last investigation we've found out that configuration source passed during constructor call is 'NULL_SOURCE'. It's a bit confusing because it conflicts with NULL_SOURCE definition
> {noformat}
> /**
> * ConfigurationSource to use with Configurations that do not require a "real" configuration source.
> */
> public static final ConfigurationSource NULL_SOURCE = new ConfigurationSource(new byte[0]);
> {noformat}
> because actually we have a 'composite' or 'multiple' configuration sources which will be used later to produce real configuration.
> The question is: do you mind to create 'COMPOSITE_SOURCE' constant and use it in CompositeConfiguration?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)