You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by al...@apache.org on 2022/08/18 20:47:52 UTC

[arrow-rs] branch master updated: Update create-tarball.sh and verify_release.sh script to skip `object_store` (#2339)

This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/master by this push:
     new 7ce6ba4b1 Update create-tarball.sh and verify_release.sh script to skip `object_store` (#2339)
7ce6ba4b1 is described below

commit 7ce6ba4b184fae19ca20ade5e9e712a435a8153b
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Thu Aug 18 16:47:48 2022 -0400

    Update create-tarball.sh and verify_release.sh script to skip `object_store` (#2339)
    
    * Update create-tarball.sh script to skip object_store
    
    * restore upload commands
---
 dev/release/create-tarball.sh           | 21 ++++++++++++++++++++-
 dev/release/verify-release-candidate.sh |  6 ++++--
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/dev/release/create-tarball.sh b/dev/release/create-tarball.sh
index 06320171b..0463f89f7 100755
--- a/dev/release/create-tarball.sh
+++ b/dev/release/create-tarball.sh
@@ -53,6 +53,17 @@ fi
 tag=$1
 rc=$2
 
+
+# mac tar doesn't have --delete, so use gnutar
+# e.g. brew install gtar
+if command -v gtar &> /dev/null
+then
+    echo "using gtar (gnu)tar"
+    tar=gtar
+else
+    tar=tar
+fi
+
 release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag})
 
 release=apache-arrow-rs-${tag}
@@ -103,10 +114,18 @@ MAIL
 echo "---------------------------------------------------------"
 
 
+
 # create <tarball> containing the files in git at $release_hash
 # the files in the tarball are prefixed with {tag} (e.g. 4.0.1)
+# use --delete to filter out:
+# 1. `object_store` files
+# 2. Workspace `Cargo.toml` file (which refers to object_store)
 mkdir -p ${distdir}
-(cd "${SOURCE_TOP_DIR}" && git archive ${release_hash} --prefix ${release}/ | gzip > ${tarball})
+(cd "${SOURCE_TOP_DIR}" && \
+     git archive ${release_hash} --prefix ${release}/ \
+         | $tar --delete ${release}/'object_store' \
+         | $tar --delete ${release}/'Cargo.toml' \
+         | gzip > ${tarball})
 
 echo "Running rat license checker on ${tarball}"
 ${SOURCE_DIR}/run-rat.sh ${tarball}
diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index b60465b97..00627a998 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -121,8 +121,10 @@ test_source_distribution() {
     -e 's/^parquet = "([^"]*)"/parquet = { version = "\1", path = "..\/parquet" }/g' \
     */Cargo.toml
 
-  cargo build
-  cargo test --all
+  (cd arrow && cargo build && cargo test)
+  (cd arrow-flight && cargo build && cargo test)
+  (cd parquet && cargo build && cargo test)
+  (cd parquet_derive && cargo build && cargo test)
 
   # verify that the crates can be published to crates.io
   pushd arrow