You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/23 08:24:06 UTC
[GitHub] [ozone] aryangupta1998 opened a new pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
aryangupta1998 opened a new pull request #2359:
URL: https://github.com/apache/ozone/pull/2359
## What changes were proposed in this pull request?
SCM HA uses config from SCMHAConfiguration, removing unused config related to SCM HA Ratis config in SCMConfigKeys.java
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5369#
## How was this patch tested?
Tested Manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657620148
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,6 +2053,14 @@
</description>
</property>
+ <property>
+ <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
We need to remove this from ozone-default.xml and SCMConfigKeys
And we should change below code where we are using config from SCMConfigKeys to SCMHAConfiguration. And also change it to 30000ms
```
final long requestTimeout = scm.getConfiguration()
.getTimeDuration(ScmConfigKeys.OZONE_SCM_RATIS_REQUEST_TIMEOUT_KEY,
ScmConfigKeys.OZONE_SCM_RATIS_REQUEST_TIMEOUT_DEFAULT,
TimeUnit.MILLISECONDS);
```
Should be changed as
```
final long requestTimeout =
scm.getConfiguration().getObject(SCMHAConfiguration.class)
.getRatisRequestTimeout();
```
cc @bshashikant to check if it okay to use this here also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657685362
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,6 +2053,14 @@
</description>
</property>
+ <property>
+ <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
Previously we used to use 30s, now reduce that to 10s?
```
public static final String OZONE_SCM_RATIS_REQUEST_TIMEOUT_DEFAULT
= "30s";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r656983082
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,128 +2053,6 @@
</description>
</property>
- <property>
- <name>ozone.scm.ratis.rpc.type</name>
- <value>GRPC</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>Ratis supports different kinds of transports like netty, GRPC,
- Hadoop RPC etc. This picks one of those for this cluster.
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.storage.dir</name>
- <value/>
- <tag>OZONE, SCM, HA, RATIS, STORAGE</tag>
- <description>This directory is used for storing SCM's Ratis metadata like
- logs. If this is not set then default metadata dirs is used. A warning
- will be logged if this not set. Ideally, this should be mapped to a
- fast disk like an SSD.
- If undefined, SCM ratis storage dir will fallback to ozone.metadata.dirs.
- This fallback approach is not recommended for production environments.
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.segment.size</name>
- <value>16KB</value>
- <tag>OZONE, SCM, HA, RATIS, PERFORMANCE</tag>
- <description>The size of the raft segment used by Apache Ratis on SCM.
- (16 KB by default)
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.segment.preallocated.size</name>
- <value>16KB</value>
- <tag>OZONE, SCM, HA, RATIS, PERFORMANCE</tag>
- <description>The size of the buffer which is preallocated for raft segment
- used by Apache Ratis on SCM.(16 KB by default)
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.log.appender.queue.num-elements</name>
- <value>1024</value>
- <tag>OZONE, DEBUG, SCM, HA, RATIS</tag>
- <description>Number of operation pending with Raft's Log Worker.
- </description>
- </property>
- <property>
- <name>ozone.scm.ratis.log.appender.queue.byte-limit</name>
- <value>32MB</value>
- <tag>OZONE, DEBUG, SCM, HA, RATIS</tag>
- <description>Byte limit for Raft's Log Worker queue.
- </description>
- </property>
- <property>
- <name>ozone.scm.ratis.log.purge.gap</name>
- <value>1000000</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>The minimum gap between log indices for Raft server to purge
- its log segments after taking snapshot.
- </description>
- </property>
- <property>
- <name>ozone.scm.ratis.server.request.timeout</name>
- <value>3s</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>The timeout duration for SCM's ratis server request.</description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.server.retry.cache.timeout</name>
- <value>600000ms</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>Retry Cache entry timeout for SCM's ratis server.</description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.minimum.timeout</name>
- <value>1s</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>The minimum timeout duration for SCM's Ratis server rpc.
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
And also we can rename this to ozone.scm.ratis.request.timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r656982071
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,128 +2053,6 @@
</description>
</property>
- <property>
- <name>ozone.scm.ratis.rpc.type</name>
- <value>GRPC</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>Ratis supports different kinds of transports like netty, GRPC,
- Hadoop RPC etc. This picks one of those for this cluster.
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.storage.dir</name>
- <value/>
- <tag>OZONE, SCM, HA, RATIS, STORAGE</tag>
- <description>This directory is used for storing SCM's Ratis metadata like
- logs. If this is not set then default metadata dirs is used. A warning
- will be logged if this not set. Ideally, this should be mapped to a
- fast disk like an SSD.
- If undefined, SCM ratis storage dir will fallback to ozone.metadata.dirs.
- This fallback approach is not recommended for production environments.
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.segment.size</name>
- <value>16KB</value>
- <tag>OZONE, SCM, HA, RATIS, PERFORMANCE</tag>
- <description>The size of the raft segment used by Apache Ratis on SCM.
- (16 KB by default)
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.segment.preallocated.size</name>
- <value>16KB</value>
- <tag>OZONE, SCM, HA, RATIS, PERFORMANCE</tag>
- <description>The size of the buffer which is preallocated for raft segment
- used by Apache Ratis on SCM.(16 KB by default)
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.log.appender.queue.num-elements</name>
- <value>1024</value>
- <tag>OZONE, DEBUG, SCM, HA, RATIS</tag>
- <description>Number of operation pending with Raft's Log Worker.
- </description>
- </property>
- <property>
- <name>ozone.scm.ratis.log.appender.queue.byte-limit</name>
- <value>32MB</value>
- <tag>OZONE, DEBUG, SCM, HA, RATIS</tag>
- <description>Byte limit for Raft's Log Worker queue.
- </description>
- </property>
- <property>
- <name>ozone.scm.ratis.log.purge.gap</name>
- <value>1000000</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>The minimum gap between log indices for Raft server to purge
- its log segments after taking snapshot.
- </description>
- </property>
- <property>
- <name>ozone.scm.ratis.server.request.timeout</name>
- <value>3s</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>The timeout duration for SCM's ratis server request.</description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.server.retry.cache.timeout</name>
- <value>600000ms</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>Retry Cache entry timeout for SCM's ratis server.</description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.minimum.timeout</name>
- <value>1s</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>The minimum timeout duration for SCM's Ratis server rpc.
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
This should not be removed.
And also can we move this to SCMHAConfiguration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aryangupta1998 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
aryangupta1998 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657297491
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,128 +2053,6 @@
</description>
</property>
- <property>
- <name>ozone.scm.ratis.rpc.type</name>
- <value>GRPC</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>Ratis supports different kinds of transports like netty, GRPC,
- Hadoop RPC etc. This picks one of those for this cluster.
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.storage.dir</name>
- <value/>
- <tag>OZONE, SCM, HA, RATIS, STORAGE</tag>
- <description>This directory is used for storing SCM's Ratis metadata like
- logs. If this is not set then default metadata dirs is used. A warning
- will be logged if this not set. Ideally, this should be mapped to a
- fast disk like an SSD.
- If undefined, SCM ratis storage dir will fallback to ozone.metadata.dirs.
- This fallback approach is not recommended for production environments.
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.segment.size</name>
- <value>16KB</value>
- <tag>OZONE, SCM, HA, RATIS, PERFORMANCE</tag>
- <description>The size of the raft segment used by Apache Ratis on SCM.
- (16 KB by default)
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.segment.preallocated.size</name>
- <value>16KB</value>
- <tag>OZONE, SCM, HA, RATIS, PERFORMANCE</tag>
- <description>The size of the buffer which is preallocated for raft segment
- used by Apache Ratis on SCM.(16 KB by default)
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.log.appender.queue.num-elements</name>
- <value>1024</value>
- <tag>OZONE, DEBUG, SCM, HA, RATIS</tag>
- <description>Number of operation pending with Raft's Log Worker.
- </description>
- </property>
- <property>
- <name>ozone.scm.ratis.log.appender.queue.byte-limit</name>
- <value>32MB</value>
- <tag>OZONE, DEBUG, SCM, HA, RATIS</tag>
- <description>Byte limit for Raft's Log Worker queue.
- </description>
- </property>
- <property>
- <name>ozone.scm.ratis.log.purge.gap</name>
- <value>1000000</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>The minimum gap between log indices for Raft server to purge
- its log segments after taking snapshot.
- </description>
- </property>
- <property>
- <name>ozone.scm.ratis.server.request.timeout</name>
- <value>3s</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>The timeout duration for SCM's ratis server request.</description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.server.retry.cache.timeout</name>
- <value>600000ms</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>Retry Cache entry timeout for SCM's ratis server.</description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.minimum.timeout</name>
- <value>1s</value>
- <tag>OZONE, SCM, HA, RATIS</tag>
- <description>The minimum timeout duration for SCM's Ratis server rpc.
- </description>
- </property>
-
- <property>
- <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
Again added the property 'ozone.scm.ratis.minimum.timeout' to ozone-default.xml due to test failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657694277
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,6 +2053,14 @@
</description>
</property>
+ <property>
+ <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
30s is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 merged pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #2359:
URL: https://github.com/apache/ozone/pull/2359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657620148
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,6 +2053,14 @@
</description>
</property>
+ <property>
+ <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
We need to remove this from ozone-default.xml and SCMConfigKeys
And we should change below code where we are using config from SCMConfigKeys to SCMHAConfiguration. And also change it to 30000ms
```
final long requestTimeout = scm.getConfiguration()
.getTimeDuration(ScmConfigKeys.OZONE_SCM_RATIS_REQUEST_TIMEOUT_KEY,
ScmConfigKeys.OZONE_SCM_RATIS_REQUEST_TIMEOUT_DEFAULT,
TimeUnit.MILLISECONDS);
```
Should be changed as
```
final long requestTimeout =
scm.getConfiguration().getObject(SCMHAConfiguration.class)
.getRatisRequestTimeout();
```
cc @bshashikant to check if it okay to use this here also,as currently it is being used in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657620148
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,6 +2053,14 @@
</description>
</property>
+ <property>
+ <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
We need to remove this from ozone-default.xml and SCMConfigKeys
And we should change below code where we are using config from SCMConfigKeys to SCMHAConfiguration. And also change it to 30000ms
```
final long requestTimeout = scm.getConfiguration()
.getTimeDuration(ScmConfigKeys.OZONE_SCM_RATIS_REQUEST_TIMEOUT_KEY,
ScmConfigKeys.OZONE_SCM_RATIS_REQUEST_TIMEOUT_DEFAULT,
TimeUnit.MILLISECONDS);
```
Should be changed as
```
final long requestTimeout =
scm.getConfiguration().getObject(SCMHAConfiguration.class)
.getRatisRequestTimeout();
```
cc @bshashikant to check if it okay to use this here also,as currently it is being used in
```
Rpc.setRequestTimeout(properties, TimeDuration.valueOf(
conf.getRatisRequestTimeout(), TimeUnit.MILLISECONDS));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aryangupta1998 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
aryangupta1998 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657704284
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,6 +2053,14 @@
</description>
</property>
+ <property>
+ <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
I have modified the code, now it will use the config from SCMHAConfiguration and also have set the default value to 30 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657620696
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java
##########
@@ -130,7 +130,7 @@
"operation for SCM")
private long ratisSnapshotThreshold = 1000L;
- @Config(key = "ratis.request.timeout",
+ @Config(key = "ratis.minimum.timeout",
Review comment:
minimum -> request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#issuecomment-868322517
+1 LGTM.
I see few more issues with SCMHAConfiguration, let me open a new Jira for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aryangupta1998 commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
aryangupta1998 commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657704498
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java
##########
@@ -130,7 +130,7 @@
"operation for SCM")
private long ratisSnapshotThreshold = 1000L;
- @Config(key = "ratis.request.timeout",
+ @Config(key = "ratis.minimum.timeout",
Review comment:
Changed minimum -> request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#issuecomment-868322709
Thank You @aryangupta1998 for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#issuecomment-868326610
Opened new Jira https://issues.apache.org/jira/browse/HDDS-5391 for fixing other issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on a change in pull request #2359: HDDS-5369. Cleanup unused configuration related to SCM HA
Posted by GitBox <gi...@apache.org>.
bshashikant commented on a change in pull request #2359:
URL: https://github.com/apache/ozone/pull/2359#discussion_r657678403
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2053,6 +2053,14 @@
</description>
</property>
+ <property>
+ <name>ozone.scm.ratis.minimum.timeout</name>
Review comment:
its okay. let's do this change. Also, let's change the default to 10s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org