You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/06/07 00:04:37 UTC

[GitHub] [doris] yiguolei commented on a diff in pull request #20521: [improvement](column reader) improve column reader options and delete not necessary options

yiguolei commented on code in PR #20521:
URL: https://github.com/apache/doris/pull/20521#discussion_r1220571421


##########
be/src/olap/rowset/segment_v2/page_io.cpp:
##########
@@ -154,13 +154,11 @@ Status PageIO::read_and_decompress_page(const PageReadOptions& opts, PageHandle*
         opts.stats->compressed_bytes_read += page_size;
     }
 
-    if (opts.verify_checksum) {

Review Comment:
   Why remove this if? Because it is always true?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org