You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/01 12:47:40 UTC

[GitHub] [arrow] liyafan82 commented on a change in pull request #7543: ARROW-9221: [Java] account for big-endian buffers in ArrowBuf.setBytes

liyafan82 commented on a change in pull request #7543:
URL: https://github.com/apache/arrow/pull/7543#discussion_r448338460



##########
File path: java/memory/src/main/java/org/apache/arrow/memory/ArrowBuf.java
##########
@@ -872,6 +874,7 @@ public void setBytes(long index, ByteBuffer src) {
           --length;
           ++dstAddress;
         }
+        src.order(originalByteOrder);

Review comment:
       should we place this in a finally block?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org