You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/01 16:53:00 UTC
[GitHub] [superset] codecov-io commented on pull request #12865: feat(dashboard_rbac): dashboards API support for roles create/update + roles validation
codecov-io commented on pull request #12865:
URL: https://github.com/apache/superset/pull/12865#issuecomment-770998722
# [Codecov](https://codecov.io/gh/apache/superset/pull/12865?src=pr&el=h1) Report
> Merging [#12865](https://codecov.io/gh/apache/superset/pull/12865?src=pr&el=desc) (8bd211f) into [master](https://codecov.io/gh/apache/superset/commit/9a7fba810e5bc3a94746117937163c1bfaea19ee?el=desc) (9a7fba8) will **decrease** coverage by `3.61%`.
> The diff coverage is `89.79%`.
[](https://codecov.io/gh/apache/superset/pull/12865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12865 +/- ##
==========================================
- Coverage 67.04% 63.42% -3.62%
==========================================
Files 1022 489 -533
Lines 50186 30220 -19966
Branches 5204 0 -5204
==========================================
- Hits 33647 19168 -14479
+ Misses 16404 11052 -5352
+ Partials 135 0 -135
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.42% <89.79%> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.63% <ø> (ø)` | |
| [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | `83.07% <70.58%> (-5.61%)` | :arrow_down: |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.00% <100.00%> (+0.69%)` | :arrow_up: |
| [superset/commands/utils.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvdXRpbHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `93.87% <100.00%> (+1.56%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.83% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/security/manager.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `90.47% <100.00%> (-0.55%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| ... and [558 more](https://codecov.io/gh/apache/superset/pull/12865/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12865?src=pr&el=footer). Last update [9a7fba8...48718ea](https://codecov.io/gh/apache/superset/pull/12865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org