You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/02/23 04:20:20 UTC
Review Request 43864: Fix typo of roles doc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43864/
-----------------------------------------------------------
Review request for mesos and Neil Conway.
Repository: mesos
Description
-------
Fix typo of roles doc.
Diffs
-----
docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83
docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35
Diff: https://reviews.apache.org/r/43864/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 43864: Fix typo of roles doc.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43864/#review120287
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43864]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 23, 2016, 3:20 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43864/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 3:20 a.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix typo of roles doc.
>
>
> Diffs
> -----
>
> docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83
> docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35
>
> Diff: https://reviews.apache.org/r/43864/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 43864: Fix typo of roles doc.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43864/#review120531
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Feb. 24, 2016, 3:34 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43864/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 3:34 a.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix typo of roles doc.
>
>
> Diffs
> -----
>
> docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83
> docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35
> src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b
>
> Diff: https://reviews.apache.org/r/43864/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 43864: Fix typo of roles doc.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43864/#review120480
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43864]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 24, 2016, 3:34 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43864/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 3:34 a.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix typo of roles doc.
>
>
> Diffs
> -----
>
> docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83
> docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35
> src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b
>
> Diff: https://reviews.apache.org/r/43864/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 43864: Fix typo of roles doc.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43864/
-----------------------------------------------------------
(Updated Feb. 24, 2016, 11:34 a.m.)
Review request for mesos and Neil Conway.
Changes
-------
Address comments.
Repository: mesos
Description
-------
Fix typo of roles doc.
Diffs (updated)
-----
docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83
docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35
src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b
Diff: https://reviews.apache.org/r/43864/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 43864: Fix typo of roles doc.
Posted by Klaus Ma <kl...@gmail.com>.
> On Feb. 24, 2016, 2:06 a.m., Neil Conway wrote:
> > The right place to make this fix is in `src/master/http.cpp`, and then rerun `support/generate-endpoint-help.py`. Seems like `Master::Http::ROLES_HELP` is missing commas in `DESCRIPTION`.
You're right, we missed commas in `Master::Http::ROLES_HELP` `DESCRIPTION`. Update the patches to address this comments :).
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43864/#review120347
-----------------------------------------------------------
On Feb. 24, 2016, 11:34 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43864/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 11:34 a.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix typo of roles doc.
>
>
> Diffs
> -----
>
> docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83
> docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35
> src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b
>
> Diff: https://reviews.apache.org/r/43864/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 43864: Fix typo of roles doc.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43864/#review120347
-----------------------------------------------------------
The right place to make this fix is in `src/master/http.cpp`, and then rerun `support/generate-endpoint-help.py`. Seems like `Master::Http::ROLES_HELP` is missing commas in `DESCRIPTION`.
- Neil Conway
On Feb. 23, 2016, 3:20 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43864/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 3:20 a.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix typo of roles doc.
>
>
> Diffs
> -----
>
> docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83
> docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35
>
> Diff: https://reviews.apache.org/r/43864/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>