You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Daniel Naber (JIRA)" <ji...@apache.org> on 2007/08/15 22:41:30 UTC
[jira] Created: (COCOON-2114) fix sorting in TraversableGenerator
fix sorting in TraversableGenerator
-----------------------------------
Key: COCOON-2114
URL: https://issues.apache.org/jira/browse/COCOON-2114
Project: Cocoon
Issue Type: Bug
Components: * Cocoon Core
Affects Versions: 2.2-dev (Current SVN)
Reporter: Daniel Naber
Attachments: TraversableGenerator.diff
The sort in TraversableGenerator.java doesn't work, because the array which is sorted is actually never used. The attached patch fixes that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2114) fix sorting in TraversableGenerator
Posted by "Daniel Naber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520316 ]
Daniel Naber commented on COCOON-2114:
--------------------------------------
One more thing: the default is to sort by name, but the javadoc says the default is "system order".
> fix sorting in TraversableGenerator
> -----------------------------------
>
> Key: COCOON-2114
> URL: https://issues.apache.org/jira/browse/COCOON-2114
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Daniel Naber
> Attachments: TraversableGenerator.diff
>
>
> The sort in TraversableGenerator.java doesn't work, because the array which is sorted is actually never used. The attached patch fixes that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2114) fix sorting in TraversableGenerator
Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558391#action_12558391 ]
Grzegorz Kossakowski commented on COCOON-2114:
----------------------------------------------
Hi Daniel
I would like to apply your patch but it needs a test-coverage. Could you provide a simple test checking if sorting works as expected?
> fix sorting in TraversableGenerator
> -----------------------------------
>
> Key: COCOON-2114
> URL: https://issues.apache.org/jira/browse/COCOON-2114
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Daniel Naber
> Attachments: TraversableGenerator.diff
>
>
> The sort in TraversableGenerator.java doesn't work, because the array which is sorted is actually never used. The attached patch fixes that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2114) fix sorting in TraversableGenerator
Posted by "Daniel Naber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Naber updated COCOON-2114:
---------------------------------
Attachment: TraversableGenerator.diff
> fix sorting in TraversableGenerator
> -----------------------------------
>
> Key: COCOON-2114
> URL: https://issues.apache.org/jira/browse/COCOON-2114
> Project: Cocoon
> Issue Type: Bug
> Components: * Cocoon Core
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Daniel Naber
> Attachments: TraversableGenerator.diff
>
>
> The sort in TraversableGenerator.java doesn't work, because the array which is sorted is actually never used. The attached patch fixes that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.