You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2011/03/05 00:54:45 UTC
[jira] Created: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
--------------------------------------------------------------------------
Key: PIG-1884
URL: https://issues.apache.org/jira/browse/PIG-1884
Project: Pig
Issue Type: Bug
Affects Versions: 0.9.0
Reporter: Daniel Dai
Assignee: Thejas M Nair
Fix For: 0.9.0
After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-1884:
-------------------------------
Attachment: PIG-1884.08.1.patch
PIG-1884.08.1.patch - patch generated for 0.8 which includes changes in 0.9 patch, except for ones in TestHBaseStorage.
> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
> Key: PIG-1884
> URL: https://issues.apache.org/jira/browse/PIG-1884
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0, 0.9.0
> Reporter: Daniel Dai
> Assignee: Thejas M Nair
> Fix For: 0.8.0, 0.9.0
>
> Attachments: PIG-1884.08.1.patch, PIG-1884.1.patch, PIG-1884.2.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003508#comment-13003508 ]
Daniel Dai commented on PIG-1884:
---------------------------------
+1
> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
> Key: PIG-1884
> URL: https://issues.apache.org/jira/browse/PIG-1884
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Thejas M Nair
> Fix For: 0.9.0
>
> Attachments: PIG-1884.1.patch, PIG-1884.2.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair resolved PIG-1884.
--------------------------------
Resolution: Fixed
Unit tests and test-patch passed with PIG-1884.08.1.patch. Patch committed to 0.8 branch.
> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
> Key: PIG-1884
> URL: https://issues.apache.org/jira/browse/PIG-1884
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0, 0.9.0
> Reporter: Daniel Dai
> Assignee: Thejas M Nair
> Fix For: 0.9.0, 0.8.0
>
> Attachments: PIG-1884.08.1.patch, PIG-1884.1.patch, PIG-1884.2.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-1884:
-------------------------------
Affects Version/s: 0.8.0
Fix Version/s: 0.8.0
> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
> Key: PIG-1884
> URL: https://issues.apache.org/jira/browse/PIG-1884
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.8.0, 0.9.0
> Reporter: Daniel Dai
> Assignee: Thejas M Nair
> Fix For: 0.8.0, 0.9.0
>
> Attachments: PIG-1884.1.patch, PIG-1884.2.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-1884:
-------------------------------
Attachment: PIG-1884.1.patch
> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
> Key: PIG-1884
> URL: https://issues.apache.org/jira/browse/PIG-1884
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Thejas M Nair
> Fix For: 0.9.0
>
> Attachments: PIG-1884.1.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003568#comment-13003568 ]
Dmitriy V. Ryaboy commented on PIG-1884:
----------------------------------------
Alan specifically emailed me asking to stop reindenting things cause it made patches hard to read:).
Sorry about breaking the test.
What's the change to start mini hbase cluster?
> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
> Key: PIG-1884
> URL: https://issues.apache.org/jira/browse/PIG-1884
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Thejas M Nair
> Fix For: 0.9.0
>
> Attachments: PIG-1884.1.patch, PIG-1884.2.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair updated PIG-1884:
-------------------------------
Attachment: PIG-1884.2.patch
With PIG-1884.1.patch all (non-contrib) unit tests passed, except for TestJobSubmission.
PIG-1884.2.patch has additional change to start mini hbase cluster. It also fixes the code indentation in TestHBaseStorage to comply with the pig coding standard.
> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
> Key: PIG-1884
> URL: https://issues.apache.org/jira/browse/PIG-1884
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Thejas M Nair
> Fix For: 0.9.0
>
> Attachments: PIG-1884.1.patch, PIG-1884.2.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003554#comment-13003554 ]
Thejas M Nair commented on PIG-1884:
------------------------------------
Patch committed to trunk.
> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
> Key: PIG-1884
> URL: https://issues.apache.org/jira/browse/PIG-1884
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Thejas M Nair
> Fix For: 0.9.0
>
> Attachments: PIG-1884.1.patch, PIG-1884.2.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIG-1884) Change ReadToEndLoader.setLocation not
throw UnsupportedOperationException
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003580#comment-13003580 ]
Thejas M Nair commented on PIG-1884:
------------------------------------
bq. Alan specifically emailed me asking to stop reindenting things cause it made patches hard to read
Because of the indentation issues, the code was very hard to read ! There was only a one line change other than indentation change in TestHBaseStorage, so I guess it was not that hard to review the patch this time.
bq. What's the change to start mini hbase cluster?
Sorry, my comment was incomplete . The change to start mini hbase cluster was only in TestJobSubmission.java .
I am creating a new patch to fix the related unit test failures in 0.8, as this patch has merge issues in 0.8. I will submit that after running unit tests on 0.8.
> Change ReadToEndLoader.setLocation not throw UnsupportedOperationException
> --------------------------------------------------------------------------
>
> Key: PIG-1884
> URL: https://issues.apache.org/jira/browse/PIG-1884
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Thejas M Nair
> Fix For: 0.9.0
>
> Attachments: PIG-1884.1.patch, PIG-1884.2.patch
>
>
> After PIG-1680, we will call LoadFunc.setLocation() before launching hadoop job. This change cause TestExampleGenerator fail. The reason is ReadToEndLoader.setLocation() will throw UnsupportedOperationException. We never get to this point before PIG-1680.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira