You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hartmut Lang (Commented) (JIRA)" <ji...@apache.org> on 2012/03/04 15:43:59 UTC

[jira] [Commented] (ZOOKEEPER-271) Better command line parsing in ZookeeperMain.

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221904#comment-13221904 ] 

Hartmut Lang commented on ZOOKEEPER-271:
----------------------------------------

A attached a patch with my work to refactor the CLI to use commons-cli.
Every command has now its own java-class, with CliCommand.java as base.class.

The options for some commands were changed to match the option usage in commons-cli.
But to maintain the compatibility the old argument style for these commands was preserved. This could be removed in a future revision.

The commands with changed options are:
get [-s] [-w] path, old version was: get path [watch]
ls [-w] path, old version was ls path [watch]
ls2 [-w] path, old version was ls2 path [watch]
stat [-w] path, old version was stat path [watch]

Please have a look.

                
> Better command line parsing in ZookeeperMain.
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-271
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-271
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.0.0, 3.0.1
>            Reporter: Mahadev konar
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-271-1.patch
>
>
> The command line parsing in zookeepermain is very basic.We should use some kind of cli parsing (commons-cli?) or something else that is standard and improve our command line parsing. This will remove the scattered code that we have in zookeepermain and we will have much better command line parsing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira