[GitHub] [pinot] siddharthteotia commented on a diff in pull request #8499: DataTable deserialization improvements

[GitBox <gi...@apache.org>]

siddharthteotia commented on code in PR #8499:
URL: https://github.com/apache/pinot/pull/8499#discussion_r847771725


##########
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java:
##########
@@ -350,32 +340,29 @@ private byte[] serializeMetadata()
    * This is to make V3 implementation keep the consumers of Map<String, String> getMetadata() API in the code happy
    * by internally converting it.
    */
-  private Map<String, String> deserializeMetadata(byte[] bytes)
+  private Map<String, String> deserializeMetadata(ByteBuffer buffer)

Review Comment:
   Can we add a comment / note stating that the caller of this method assumes that ByteBuffer position is moved accordingly by reads done in this method and so we should use relative get/read methods ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org