[GitHub] imay commented on a change in pull request #344: Fix worng query result when column value is Null

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #344: Fix worng query result when column value is Null
URL: https://github.com/apache/incubator-doris/pull/344#discussion_r235747749
 
 

 ##########
 File path: be/src/exec/olap_common.h
 ##########
 @@ -662,6 +662,8 @@ Status OlapScanKeys::extend_scan_key(ColumnValueRange<T>& range) {
         return Status::OK;
     }
 
+    bool _has_converted = false;
 
 Review comment:
   Only member variable's name starts with '_', so change it to `has_converted`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org