[GitHub] [logging-log4j2] garydgregory commented on pull request #704: Multiple small improvements in Log4j 1.x configuration parsing (including LOG4J2-3328)

[GitBox <gi...@apache.org>]

garydgregory commented on pull request #704:
URL: https://github.com/apache/logging-log4j2/pull/704#issuecomment-1013915115


   Hello @ppkarwasz 
   Thank you for your PR. You must have missed in Jira that the ticket https://issues.apache.org/jira/browse/LOG4J2-3328 was assigned to me, so we were both working on the same issue at the same time. I committed a fix to branches `release-2.x` and `master`. The fix must be different from what you propose here because we incorrectly had the abstract builder set up to use the Log4j 2 string substitutor instead of the Log4j 1 option converter. This has been addressed. This PR also mixes in too many different changes and covers too many files (39!) IMO for a reasonable review. Granted, refactoring common code requires touching a lot of files, I understand that. Nevertheless, I think there are still valuable changes here that we could review after you rebase this PR on branch `release-2.x`.
   Thank you for your efforts and patience :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org