You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amar Kamat (JIRA)" <ji...@apache.org> on 2009/06/17 10:58:07 UTC

[jira] Created: (HADOOP-6065) TestRunningTaskLimit doesnt work as expected

TestRunningTaskLimit doesnt work as expected
--------------------------------------------

                 Key: HADOOP-6065
                 URL: https://issues.apache.org/jira/browse/HADOOP-6065
             Project: Hadoop Core
          Issue Type: Bug
          Components: test
            Reporter: Amar Kamat


I see the following code in TestRunningTaskLimit
{code}
JobConf jobConf = createWaitJobConf(mr, "job1", 20, 20);
    jobConf.setRunningMapLimit(5);
    jobConf.setRunningReduceLimit(3);
    
    // Submit the job
    RunningJob rJob = (new JobClient(jobConf)).submitJob(jobConf);
    
    // Wait 20 seconds for it to start up
    UtilsForTests.waitFor(20000);
    
    // Check the number of running tasks
    JobTracker jobTracker = mr.getJobTrackerRunner().getJobTracker();
    JobInProgress jip = jobTracker.getJob(rJob.getID());
    assertEquals(5, jip.runningMaps());
    assertEquals(3, jip.runningReduces());
{code}

This check is timing based and might not work as expected. Instead we can run a job with > 5 maps (all waiting) and then wait for the job to reach a stable state and then test if exactly 5 maps were scheduled or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HADOOP-6065) TestRunningTaskLimit doesnt work as expected

Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721045#action_12721045 ] 

Hemanth Yamijala commented on HADOOP-6065:
------------------------------------------

bq. and then wait for the job to reach a stable state and then test if exactly 5 maps were scheduled or not.

This is prone to errors as well. Look at HADOOP-6064 for an example.

> TestRunningTaskLimit doesnt work as expected
> --------------------------------------------
>
>                 Key: HADOOP-6065
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6065
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Amar Kamat
>
> I see the following code in TestRunningTaskLimit
> {code}
> JobConf jobConf = createWaitJobConf(mr, "job1", 20, 20);
>     jobConf.setRunningMapLimit(5);
>     jobConf.setRunningReduceLimit(3);
>     
>     // Submit the job
>     RunningJob rJob = (new JobClient(jobConf)).submitJob(jobConf);
>     
>     // Wait 20 seconds for it to start up
>     UtilsForTests.waitFor(20000);
>     
>     // Check the number of running tasks
>     JobTracker jobTracker = mr.getJobTrackerRunner().getJobTracker();
>     JobInProgress jip = jobTracker.getJob(rJob.getID());
>     assertEquals(5, jip.runningMaps());
>     assertEquals(3, jip.runningReduces());
> {code}
> This check is timing based and might not work as expected. Instead we can run a job with > 5 maps (all waiting) and then wait for the job to reach a stable state and then test if exactly 5 maps were scheduled or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.