You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by isper3at <gi...@git.apache.org> on 2016/05/17 17:31:05 UTC

[GitHub] incubator-rya pull request: RYA-73 added timestamp to mongoDB DAO

GitHub user isper3at opened a pull request:

    https://github.com/apache/incubator-rya/pull/43

    RYA-73 added timestamp to mongoDB DAO

    Changed the mongo storage strategy to now
    include timestamp in the [de]serialization
    of RyaStatements.
    
    The timestamp is added at insertion timein the DAO
    
    Added test for [de]serialize
    Added test for timestamp in the DAO
    Added failsafe to mongo rya for integration test framework
    
    [Jira](https://issues.apache.org/jira/browse/RYA-73)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/isper3at/incubator-rya mongoTimestamp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit f6d2db3557c093dde24f445711bec4211824233b
Author: isper3at <sm...@gmail.com>
Date:   2016-05-09T18:29:18Z

    RYA-73 added timestamp to mongoDB DAO
    
    Changed the mongo storage strategy to now
    include timestamp in the [de]serialization
    of RyaStatements.
    
    The timestamp is added at insertion timein the DAO
    
    Added test for [de]serialize
    Added test for timestamp in the DAO

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya issue #43: RYA-73 added timestamp to mongoDB DAO

Posted by AmilaWijayarathna <gi...@git.apache.org>.
Github user AmilaWijayarathna commented on the issue:

    https://github.com/apache/incubator-rya/pull/43
  
    Hi @isper3at ,
    While running apache-yetus pre-commit checks with this PR manually, I am getting following warnings,
    "The patch has 6  line(s) that end in whitespace."
    "The patch 48 line(s) with tabs." 
    Seems like this PR contains those formatting issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya issue #43: RYA-73 added timestamp to mongoDB DAO

Posted by isper3at <gi...@git.apache.org>.
Github user isper3at commented on the issue:

    https://github.com/apache/incubator-rya/pull/43
  
    updated, should be fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya issue #43: RYA-73 added timestamp to mongoDB DAO

Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:

    https://github.com/apache/incubator-rya/pull/43
  
    looks good.  will merge tomorrow.  good job adding tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya issue #43: RYA-73 added timestamp to mongoDB DAO

Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:

    https://github.com/apache/incubator-rya/pull/43
  
    oh kind of not related to this pr, but should we consider adding context to the mongo composite indices?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya pull request #43: RYA-73 added timestamp to mongoDB DAO

Posted by isper3at <gi...@git.apache.org>.
Github user isper3at closed the pull request at:

    https://github.com/apache/incubator-rya/pull/43


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rya issue #43: RYA-73 added timestamp to mongoDB DAO

Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:

    https://github.com/apache/incubator-rya/pull/43
  
    merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---