You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by janzhongi <gi...@git.apache.org> on 2015/08/13 08:23:22 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
GitHub user janzhongi opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/207
ZEPPELIN-171,Add Apache Kylin interpreter
Leverage Zeppelin to interactive with Kylin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KylinOLAP/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #207
----
commit 0d1b7f8e0fd3f5d5c3af1dade8eace765a463d94
Author: jiazhong <ji...@ebay.com>
Date: 2015-07-09T05:18:29Z
add kylin interpreter
commit 9273079acec6837181f4d9547284905706b4a44a
Author: Chen <lu...@lm-shc-00399960.corp.ebay.com>
Date: 2015-07-15T03:24:05Z
format kylin output
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-133628342
My apologies. Just before merge this branch, i realized it does not contain a test. @janzhongi Would it be difficult to add a test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-135647505
I'm merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by janzhongi <gi...@git.apache.org>.
Github user janzhongi commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-134472380
@Leemoonsoo I have added KylinInterpreterTest.java ,would you please help have a review? thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-135642779
True! Looks good to me then.
Looking forward for some docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-134807635
Thanks. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by lukehan <gi...@git.apache.org>.
Github user lukehan commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-135988099
Thanks for merging, for the document, will draft something and PR again.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-135623563
@janzhongi we might need to also rebase it on latest master before merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-135623920
It would be very cool to have at least some kind of readme doc at https://github.com/apache/incubator-zeppelin/tree/gh-pages/docs/interpreter on what is Kylin and how to use it with Zeppelin and what features are supported (i.e it looks like progress indicator is not supported).
Do you guys think would be possible to add one in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-135638460
I think adding doc to gh-pages is good idea, but adding doc at gh-pages require new PR, while it is in different branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by janzhongi <gi...@git.apache.org>.
Github user janzhongi commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-134053940
@Leemoonsoo Sure ,I will commit the test before merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-132327578
merging if there is no more dicussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-132034336
Thanks!! LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-171,Add Apache Kylin int...
Posted by lukehan <gi...@git.apache.org>.
Github user lukehan commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/207#issuecomment-132090521
Cool, really great to see our PR is turn to green;-)
Thanks guys.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---