You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/08/04 11:07:43 UTC
[GitHub] [zookeeper] ztzg opened a new pull request #1733: ZOOKEEPER-4342: Fix: Robustify C client against errors during SASL negotiation
ztzg opened a new pull request #1733:
URL: https://github.com/apache/zookeeper/pull/1733
Before this, the client was ignoring the error field of the response header, and only considering SASL-level errors.
This commit makes it consider `hdr.err`. It also zeroes the `res` data structure, to avoid a crash in `deallocate` if `deserialize` is skipped, and sets `input_buffer` to `NULL` to avoid a double-free.
(I looked into adding a non-regression test, but doing so requires adding quite a bit of infrastructure to the mocks so that the SASL library can be correctly initialized. Punting for now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1733: ZOOKEEPER-4342: Fix: Robustify C client against errors during SASL negotiation
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1733:
URL: https://github.com/apache/zookeeper/pull/1733#issuecomment-905445492
@eolivelli: AFAICT, this is ready to go. Should I take care of merging it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1733: ZOOKEEPER-4342: Fix: Robustify C client against errors during SASL negotiation
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1733:
URL: https://github.com/apache/zookeeper/pull/1733#issuecomment-905448067
committed to master and to branch-3.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1733: ZOOKEEPER-4342: Fix: Robustify C client against errors during SASL negotiation
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1733:
URL: https://github.com/apache/zookeeper/pull/1733#issuecomment-892570858
@eolivelli: It would be good to have this in 3.7.1 (even though it seems difficult to trigger in practice with the current server).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli closed pull request #1733: ZOOKEEPER-4342: Fix: Robustify C client against errors during SASL negotiation
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1733:
URL: https://github.com/apache/zookeeper/pull/1733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1733: ZOOKEEPER-4342: Fix: Robustify C client against errors during SASL negotiation
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1733:
URL: https://github.com/apache/zookeeper/pull/1733#issuecomment-892570858
@eolivelli: It would be good to have this in 3.7.1 (even though it seems difficult to trigger in practice with the current server).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1733: ZOOKEEPER-4342: Fix: Robustify C client against errors during SASL negotiation
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1733:
URL: https://github.com/apache/zookeeper/pull/1733#issuecomment-905446007
merging it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1733: ZOOKEEPER-4342: Fix: Robustify C client against errors during SASL negotiation
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1733:
URL: https://github.com/apache/zookeeper/pull/1733#issuecomment-905452818
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org