You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/07 11:47:00 UTC
[GitHub] [airflow] potiuk opened a new pull request #12878: Adds airflow as viable docker command in official image
potiuk opened a new pull request #12878:
URL: https://github.com/apache/airflow/pull/12878
The change is backwards-compatible. It still allows to pass airflow
command without "airflow" as first parameter, but you can now
also pass "airflow" and the rest of the parameters will
be treated as "airflow" command parameters.
Documentation is updated to reflect the entrypoint behaviour
including _CMD option in SQL connections.
Part of #12762 and #12602
Partially extracted from #12766
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12878: Adds airflow as viable docker command in official image
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12878:
URL: https://github.com/apache/airflow/pull/12878
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12878: Adds airflow as viable docker command in official image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12878:
URL: https://github.com/apache/airflow/pull/12878#discussion_r537452052
##########
File path: scripts/in_container/prod/entrypoint_prod.sh
##########
@@ -111,6 +111,19 @@ else
verify_db_connection "${AIRFLOW__CORE__SQL_ALCHEMY_CONN}"
fi
+# The Bash and python commands still should verify the basic connections so they are run after the
Review comment:
Yeah. you can always NOT pass the SQL variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12878: Adds airflow as viable docker command in official image
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12878:
URL: https://github.com/apache/airflow/pull/12878#discussion_r537449963
##########
File path: scripts/in_container/prod/entrypoint_prod.sh
##########
@@ -111,6 +111,19 @@ else
verify_db_connection "${AIRFLOW__CORE__SQL_ALCHEMY_CONN}"
fi
+# The Bash and python commands still should verify the basic connections so they are run after the
Review comment:
Oh this didn't actually change behaviour/in fact it's better now. NM :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12878: Adds airflow as viable docker command in official image
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12878:
URL: https://github.com/apache/airflow/pull/12878#issuecomment-739911876
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #12878: Adds airflow as viable docker command in official image
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12878:
URL: https://github.com/apache/airflow/pull/12878#discussion_r537449493
##########
File path: scripts/in_container/prod/entrypoint_prod.sh
##########
@@ -111,6 +111,19 @@ else
verify_db_connection "${AIRFLOW__CORE__SQL_ALCHEMY_CONN}"
fi
+# The Bash and python commands still should verify the basic connections so they are run after the
Review comment:
I'm not sure I agree with this -- if we aren't running airflow, we likely want to do something else, often related to debugging.
Hmm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12878: Adds airflow as viable docker command in official image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12878:
URL: https://github.com/apache/airflow/pull/12878#discussion_r537453057
##########
File path: scripts/in_container/prod/entrypoint_prod.sh
##########
@@ -111,6 +111,19 @@ else
verify_db_connection "${AIRFLOW__CORE__SQL_ALCHEMY_CONN}"
fi
+# The Bash and python commands still should verify the basic connections so they are run after the
Review comment:
And this is written now in this sequence in the docs -> I updated the "what happens in entrypoint" docs and made sure that the sequence of things described there corresponds to the entrypoint script
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12878: Adds airflow as viable docker command in official image
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12878:
URL: https://github.com/apache/airflow/pull/12878#discussion_r537453057
##########
File path: scripts/in_container/prod/entrypoint_prod.sh
##########
@@ -111,6 +111,19 @@ else
verify_db_connection "${AIRFLOW__CORE__SQL_ALCHEMY_CONN}"
fi
+# The Bash and python commands still should verify the basic connections so they are run after the
Review comment:
And this is written now in this sequence in the docs -> I updated the "what happens in entrypoint docs and made sure that the sequence of things described there corresponds to the entrypoint script
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org