[GitHub] gbates101 commented on a change in pull request #5252: Use verbose name in SQL Lab database dropdown

[GitBox <gi...@apache.org>]

gbates101 commented on a change in pull request #5252: Use verbose name in SQL Lab database dropdown
URL: https://github.com/apache/incubator-superset/pull/5252#discussion_r196983111
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/SqlEditorLeftBar.jsx
 ##########
 @@ -155,7 +158,7 @@ class SqlEditorLeftBar extends React.PureComponent {
             dataEndpoint={
               '/databaseasync/api/' +
               'read?_flt_0_expose_in_sqllab=1&' +
-              '_oc_DatabaseAsync=database_name&' +
+              '_oc_DatabaseAsync=verbose_name&' +
 
 Review comment:
   Hm, yeah. However, if verbose names are displayed while ordering by database name, then it could potentially be just as confusing. Not sure how to address this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org