You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sunchao (via GitHub)" <gi...@apache.org> on 2023/09/27 15:34:35 UTC

[GitHub] [spark] sunchao commented on a diff in pull request #43141: [SPARK-44034][TESTS][3.4] Add a new test group for sql module

sunchao commented on code in PR #43141:
URL: https://github.com/apache/spark/pull/43141#discussion_r1338801365


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala:
##########
@@ -220,7 +220,8 @@ class QueryExecutionSuite extends SharedSparkSession {
     assertNoTag(tag5, df.queryExecution.sparkPlan)
   }
 
-  test("Logging plan changes for execution") {
+  // TODO(SPARK-44074): re-enable this test after SPARK-44074 resolved
+  ignore("Logging plan changes for execution") {

Review Comment:
   > Can the changes of [SPARK-44074](https://issues.apache.org/jira/browse/SPARK-44074) be merged into the current PR?
   
   @LuciferYang OK for me, we can also just cherry-pick it separately after this PR. Either way is fine IMO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org