You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Nathan Beyer (Apache) (JIRA)" <ji...@codehaus.org> on 2007/02/25 20:27:15 UTC

[jira] Created: (MRM-293) [archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows

[archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows
---------------------------------------------------------------------------

                 Key: MRM-293
                 URL: http://jira.codehaus.org/browse/MRM-293
             Project: Archiva
          Issue Type: Bug
    Affects Versions: 1.0
         Environment: Windows XP SP2, Sun JDK 5 Update 11, Maven 2.0.5
            Reporter: Nathan Beyer (Apache)


The test org.apache.maven.archiva.common.utils.BaseFileTest won't pass on Windows platform, because it doesn't compensate for drive letters being adding to the absolute paths. I've added some simple utility methods and tweaked the expected values to compensate for this. I don't have a Linux box to test on, so I haven't validated that they still work there, so the committer should verify the tests on a Linux or Unix box.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-293) [archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arnaud Heritier updated MRM-293:
--------------------------------

    Patch attached: Yes

> [archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows
> ---------------------------------------------------------------------------
>
>                 Key: MRM-293
>                 URL: http://jira.codehaus.org/browse/MRM-293
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.0
>         Environment: Windows XP SP2, Sun JDK 5 Update 11, Maven 2.0.5
>            Reporter: Nathan Beyer (Apache)
>         Attachments: GenericArtifactConsumerTest.diff
>
>
> The test org.apache.maven.archiva.common.utils.BaseFileTest won't pass on Windows platform, because it doesn't compensate for drive letters being adding to the absolute paths. I've added some simple utility methods and tweaked the expected values to compensate for this. I don't have a Linux box to test on, so I haven't validated that they still work there, so the committer should verify the tests on a Linux or Unix box.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-293) [archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows

Posted by "Nathan Beyer (Apache) (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nathan Beyer (Apache) updated MRM-293:
--------------------------------------

    Attachment: GenericArtifactConsumerTest.diff

GenerifArtifactConsumerTest.diff is a patch to correct this test case.

> [archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows
> ---------------------------------------------------------------------------
>
>                 Key: MRM-293
>                 URL: http://jira.codehaus.org/browse/MRM-293
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.0
>         Environment: Windows XP SP2, Sun JDK 5 Update 11, Maven 2.0.5
>            Reporter: Nathan Beyer (Apache)
>         Attachments: GenericArtifactConsumerTest.diff
>
>
> The test org.apache.maven.archiva.common.utils.BaseFileTest won't pass on Windows platform, because it doesn't compensate for drive letters being adding to the absolute paths. I've added some simple utility methods and tweaked the expected values to compensate for this. I don't have a Linux box to test on, so I haven't validated that they still work there, so the committer should verify the tests on a Linux or Unix box.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-293) [archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows

Posted by "Nathan Beyer (Apache) (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88497 ] 

Nathan Beyer (Apache) commented on MRM-293:
-------------------------------------------

I cloned MRM-292, because this issue has the same root cause, hardcoded separators in paths of the test cases. This issue is related to the test org.apache.maven.archiva.common.consumers.GenericArtifactConsumerTest.

> [archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows
> ---------------------------------------------------------------------------
>
>                 Key: MRM-293
>                 URL: http://jira.codehaus.org/browse/MRM-293
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.0
>         Environment: Windows XP SP2, Sun JDK 5 Update 11, Maven 2.0.5
>            Reporter: Nathan Beyer (Apache)
>
> The test org.apache.maven.archiva.common.utils.BaseFileTest won't pass on Windows platform, because it doesn't compensate for drive letters being adding to the absolute paths. I've added some simple utility methods and tweaked the expected values to compensate for this. I don't have a Linux box to test on, so I haven't validated that they still work there, so the committer should verify the tests on a Linux or Unix box.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRM-293) [archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows

Posted by "Joakim Erdfelt (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joakim Erdfelt closed MRM-293.
------------------------------

    Resolution: Fixed

Fixed on trunk.

> [archiva-common] Fix GenericArtifactConsumerTest, so it will run on Windows
> ---------------------------------------------------------------------------
>
>                 Key: MRM-293
>                 URL: http://jira.codehaus.org/browse/MRM-293
>             Project: Archiva
>          Issue Type: Bug
>    Affects Versions: 1.0
>         Environment: Windows XP SP2, Sun JDK 5 Update 11, Maven 2.0.5
>            Reporter: Nathan Beyer (Apache)
>            Assignee: Joakim Erdfelt
>         Attachments: GenericArtifactConsumerTest.diff
>
>
> The test org.apache.maven.archiva.common.utils.BaseFileTest won't pass on Windows platform, because it doesn't compensate for drive letters being adding to the absolute paths. I've added some simple utility methods and tweaked the expected values to compensate for this. I don't have a Linux box to test on, so I haven't validated that they still work there, so the committer should verify the tests on a Linux or Unix box.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira