You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Roberto Cortez <ra...@yahoo.com> on 2018/11/21 17:22:20 UTC
OpenTracing ServletContainerInitializer
Hi folks,
OpenTracing registers its filter with a ServletContainerInitializer. This is valid for all app being deployed on a server.
We can exclude and the app by adding a specific config and the microprofile-config file (or geronimo one). I was wondering if we couldn’t add a white / black list as well, so we don’t require to actually have to go to each app and add those files in.
What do you think?
Cheers,
Roberto
Re: OpenTracing ServletContainerInitializer
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Well there are a few points to make in perspective here:
1. It is not that complicated ;). Joke apart it is a source reading in
systeminstance props and prefixing it by the app name using AppFinder, 15
lines pby
2. On geronimo side you are embed so no real need of that (would be
misleading IMHO)
3. TomEE needs it anyway to support its own config and it must be
contextual and support a webapp prefix
Le mer. 21 nov. 2018 23:14, Roberto Cortez <ra...@yahoo.com> a écrit :
> Yes, I thought about adding a config source, it just seems to be a more
> complicated solution that just exposing a white / black list directly at
> the lib level that could be useful to a lot of things.
>
> On 21 Nov 2018, at 20:06, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
>
>
> Le mer. 21 nov. 2018 18:57, Roberto Cortez <ra...@yahoo.com> a écrit :
>
>> Hey,
>>
>> But if you set this up at the server level, you will disable it for all
>> the app and then you have to specifically add the microprofile-config to
>> each app.
>>
>
> Why?
>
> Ok i know but the question is what does prevent tomee to add a config
> source managing the config you want? Nothing, it already does it for ee ;)
>
>
>> I just wanted to avoid to add the file to the built in apps, so exclude
>> these from the init, and then each user deployed app is user choice, but
>> active by default.
>>
>> Cheers,
>> Roberto
>>
>> On 21 Nov 2018, at 17:34, Romain Manni-Bucau <rm...@gmail.com>
>> wrote:
>>
>> Hi Roberto
>>
>> This is done through microprofile config normally
>>
>> Le mer. 21 nov. 2018 18:22, Roberto Cortez <ra...@yahoo.com> a
>> écrit :
>>
>>> Hi folks,
>>>
>>> OpenTracing registers its filter with a ServletContainerInitializer.
>>> This is valid for all app being deployed on a server.
>>>
>>> We can exclude and the app by adding a specific config and the
>>> microprofile-config file (or geronimo one). I was wondering if we couldn’t
>>> add a white / black list as well, so we don’t require to actually have to
>>> go to each app and add those files in.
>>>
>>> What do you think?
>>>
>>> Cheers,
>>> Roberto
>>
>>
>>
>
Re: OpenTracing ServletContainerInitializer
Posted by Roberto Cortez <ra...@yahoo.com>.
Yes, I thought about adding a config source, it just seems to be a more complicated solution that just exposing a white / black list directly at the lib level that could be useful to a lot of things.
> On 21 Nov 2018, at 20:06, Romain Manni-Bucau <rm...@gmail.com> wrote:
>
>
>
> Le mer. 21 nov. 2018 18:57, Roberto Cortez <radcortez@yahoo.com <ma...@yahoo.com>> a écrit :
> Hey,
>
> But if you set this up at the server level, you will disable it for all the app and then you have to specifically add the microprofile-config to each app.
>
> Why?
>
> Ok i know but the question is what does prevent tomee to add a config source managing the config you want? Nothing, it already does it for ee ;)
>
>
> I just wanted to avoid to add the file to the built in apps, so exclude these from the init, and then each user deployed app is user choice, but active by default.
>
> Cheers,
> Roberto
>
>> On 21 Nov 2018, at 17:34, Romain Manni-Bucau <rmannibucau@gmail.com <ma...@gmail.com>> wrote:
>>
>> Hi Roberto
>>
>> This is done through microprofile config normally
>>
>> Le mer. 21 nov. 2018 18:22, Roberto Cortez <radcortez@yahoo.com <ma...@yahoo.com>> a écrit :
>> Hi folks,
>>
>> OpenTracing registers its filter with a ServletContainerInitializer. This is valid for all app being deployed on a server.
>>
>> We can exclude and the app by adding a specific config and the microprofile-config file (or geronimo one). I was wondering if we couldn’t add a white / black list as well, so we don’t require to actually have to go to each app and add those files in.
>>
>> What do you think?
>>
>> Cheers,
>> Roberto
>
Re: OpenTracing ServletContainerInitializer
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Le mer. 21 nov. 2018 18:57, Roberto Cortez <ra...@yahoo.com> a écrit :
> Hey,
>
> But if you set this up at the server level, you will disable it for all
> the app and then you have to specifically add the microprofile-config to
> each app.
>
Why?
Ok i know but the question is what does prevent tomee to add a config
source managing the config you want? Nothing, it already does it for ee ;)
> I just wanted to avoid to add the file to the built in apps, so exclude
> these from the init, and then each user deployed app is user choice, but
> active by default.
>
> Cheers,
> Roberto
>
> On 21 Nov 2018, at 17:34, Romain Manni-Bucau <rm...@gmail.com>
> wrote:
>
> Hi Roberto
>
> This is done through microprofile config normally
>
> Le mer. 21 nov. 2018 18:22, Roberto Cortez <ra...@yahoo.com> a écrit :
>
>> Hi folks,
>>
>> OpenTracing registers its filter with a ServletContainerInitializer. This
>> is valid for all app being deployed on a server.
>>
>> We can exclude and the app by adding a specific config and the
>> microprofile-config file (or geronimo one). I was wondering if we couldn’t
>> add a white / black list as well, so we don’t require to actually have to
>> go to each app and add those files in.
>>
>> What do you think?
>>
>> Cheers,
>> Roberto
>
>
>
Re: OpenTracing ServletContainerInitializer
Posted by Roberto Cortez <ra...@yahoo.com>.
Hey,
But if you set this up at the server level, you will disable it for all the app and then you have to specifically add the microprofile-config to each app.
I just wanted to avoid to add the file to the built in apps, so exclude these from the init, and then each user deployed app is user choice, but active by default.
Cheers,
Roberto
> On 21 Nov 2018, at 17:34, Romain Manni-Bucau <rm...@gmail.com> wrote:
>
> Hi Roberto
>
> This is done through microprofile config normally
>
> Le mer. 21 nov. 2018 18:22, Roberto Cortez <radcortez@yahoo.com <ma...@yahoo.com>> a écrit :
> Hi folks,
>
> OpenTracing registers its filter with a ServletContainerInitializer. This is valid for all app being deployed on a server.
>
> We can exclude and the app by adding a specific config and the microprofile-config file (or geronimo one). I was wondering if we couldn’t add a white / black list as well, so we don’t require to actually have to go to each app and add those files in.
>
> What do you think?
>
> Cheers,
> Roberto
Re: OpenTracing ServletContainerInitializer
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi Roberto
This is done through microprofile config normally
Le mer. 21 nov. 2018 18:22, Roberto Cortez <ra...@yahoo.com> a écrit :
> Hi folks,
>
> OpenTracing registers its filter with a ServletContainerInitializer. This
> is valid for all app being deployed on a server.
>
> We can exclude and the app by adding a specific config and the
> microprofile-config file (or geronimo one). I was wondering if we couldn’t
> add a white / black list as well, so we don’t require to actually have to
> go to each app and add those files in.
>
> What do you think?
>
> Cheers,
> Roberto