You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Beam JIRA Bot (Jira)" <ji...@apache.org> on 2020/09/28 17:08:02 UTC

[jira] [Updated] (BEAM-10604) Remove "final" modifier from FileBasedSource#getEstimatedSizeBytes?

     [ https://issues.apache.org/jira/browse/BEAM-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Beam JIRA Bot updated BEAM-10604:
---------------------------------
    Labels: stale-P2  (was: )

> Remove "final" modifier from FileBasedSource#getEstimatedSizeBytes?
> -------------------------------------------------------------------
>
>                 Key: BEAM-10604
>                 URL: https://issues.apache.org/jira/browse/BEAM-10604
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Claire McGinty
>            Priority: P2
>              Labels: stale-P2
>
> https://github.com/apache/beam/blob/6fdde4f4eab72b49b10a8bb1cb3be263c5c416b5/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java#L215
> Can we remove the "final" modifier here so subclasses have the option to override? I have a subclass implementation that performs best with a different size estimation heuristic. Similar case with the #split method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)