[GitHub] [spark] melihsozdinler commented on a diff in pull request #42112: [SPARK-44493][SQL] Support for translating catalyst expressions into partial datasource filters

["melihsozdinler (via GitHub)" <gi...@apache.org>]

melihsozdinler commented on code in PR #42112:
URL: https://github.com/apache/spark/pull/42112#discussion_r1297716611


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala:
##########
@@ -584,46 +586,46 @@ object DataSourceStrategy
    * @param translatedFilterToExpr An optional map from leaf node filter expressions to its
    *                               translated [[Filter]]. The map is used for rebuilding
    *                               [[Expression]] from [[Filter]].
-   * @param nestedPredicatePushdownEnabled Whether nested predicate pushdown is enabled.
+   * @param supportNestedPushDown Whether nested predicate push down is enabled.
+   * @param canPartialPushDown Can it be translated into partial predicate.
    * @return a `Some[Filter]` if the input [[Expression]] is convertible, otherwise a `None`.
    */
   protected[sql] def translateFilterWithMapping(
       predicate: Expression,
       translatedFilterToExpr: Option[mutable.HashMap[sources.Filter, Expression]],
-      nestedPredicatePushdownEnabled: Boolean)
+      supportNestedPushDown: Boolean,
+      canPartialPushDown: Boolean)

Review Comment:
   You can define default value as false, and send the parameter on demand if true is required by this function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org