You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/26 03:01:25 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #8310: feature: add subquery valid in ShardingInsertStatementValidator and ShardingSelectStatementValidator

codecov-io commented on pull request #8310:
URL: https://github.com/apache/shardingsphere/pull/8310#issuecomment-734044973


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8310?src=pr&el=h1) Report
   > Merging [#8310](https://codecov.io/gh/apache/shardingsphere/pull/8310?src=pr&el=desc) (e0d71de) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5687ee847b30511b2b8269e29f6a96a051fa5827?el=desc) (5687ee8) will **decrease** coverage by `1.52%`.
   > The diff coverage is `29.70%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8310/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8310?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8310      +/-   ##
   ============================================
   - Coverage     74.73%   73.21%   -1.53%     
   - Complexity      600      626      +26     
   ============================================
     Files          1483     1502      +19     
     Lines         23431    24065     +634     
     Branches       4174     4287     +113     
   ============================================
   + Hits          17512    17619     +107     
   - Misses         4768     5265     +497     
   - Partials       1151     1181      +30     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8310?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...tor/dml/impl/ShardingInsertStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvZG1sL2ltcGwvU2hhcmRpbmdJbnNlcnRTdGF0ZW1lbnRWYWxpZGF0b3IuamF2YQ==) | `31.08% <0.00%> (-60.92%)` | `0.00 <0.00> (ø)` | |
   | [...e/validator/ShardingStatementValidatorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvU2hhcmRpbmdTdGF0ZW1lbnRWYWxpZGF0b3JGYWN0b3J5LmphdmE=) | `16.00% <50.00%> (-1.40%)` | `0.00 <0.00> (ø)` | |
   | [...tor/dml/impl/ShardingSelectStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvZG1sL2ltcGwvU2hhcmRpbmdTZWxlY3RTdGF0ZW1lbnRWYWxpZGF0b3IuamF2YQ==) | `58.00% <58.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...l/prepare/driver/DriverExecutionPrepareEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcmVwYXJlL2RyaXZlci9Ecml2ZXJFeGVjdXRpb25QcmVwYXJlRW5naW5lLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...a/spring/namespace/handler/HANamespaceHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvaGFuZGxlci9IQU5hbWVzcGFjZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...g/namespace/parser/HARuleBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0hBUnVsZUJlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...rybean/ReplicaLoadBalanceAlgorithmFactoryBean.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vUmVwbGljYUxvYWRCYWxhbmNlQWxnb3JpdGhtRmFjdG9yeUJlYW4uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...or/sql/prepare/AbstractExecutionPrepareEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcmVwYXJlL0Fic3RyYWN0RXhlY3V0aW9uUHJlcGFyZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (-89.66%)` | `0.00% <0.00%> (ø%)` | |
   | [...cutor/sql/prepare/driver/jdbc/StatementOption.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9wcmVwYXJlL2RyaXZlci9qZGJjL1N0YXRlbWVudE9wdGlvbi5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...java/org/apache/shardingsphere/ha/rule/HARule.java](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS9ydWxlL0hBUnVsZS5qYXZh) | `54.54% <0.00%> (-31.57%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [83 more](https://codecov.io/gh/apache/shardingsphere/pull/8310/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8310?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8310?src=pr&el=footer). Last update [5687ee8...e0d71de](https://codecov.io/gh/apache/shardingsphere/pull/8310?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org