You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Manuwela Kanade (JIRA)" <ji...@apache.org> on 2016/11/02 05:38:58 UTC

[jira] [Commented] (MESOS-5662) Call parent class `SetUpTestCase` function in our test fixtures.

    [ https://issues.apache.org/jira/browse/MESOS-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627820#comment-15627820 ] 

Manuwela Kanade commented on MESOS-5662:
----------------------------------------

Hi [~anandmazumdar]: Created a pull request for this:
https://reviews.apache.org/r/53372/

> Call parent class `SetUpTestCase` function in our test fixtures.
> ----------------------------------------------------------------
>
>                 Key: MESOS-5662
>                 URL: https://issues.apache.org/jira/browse/MESOS-5662
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Anand Mazumdar
>            Assignee: Manuwela Kanade
>              Labels: mesosphere, newbie
>
> There are some occurrences in our code where we don't invoke the parent's {{SetUpTestCase}} method from a child test fixture. This can be a bit problematic if someone adds the method in the parent class sometime in the future. It would be good to do a sweep across the code and explicitly invoke the parent class's method.
> Some examples (there are more):
> https://github.com/apache/mesos/blob/master/src/tests/mesos.cpp#L80
> https://github.com/apache/mesos/blob/master/src/tests/module_tests.cpp#L59



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)