You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/10/20 13:42:58 UTC
[GitHub] [incubator-uniffle] leixm opened a new pull request, #274: [Bug] Get shuffle result failed caused by concurrent calls to registerShuffle
leixm opened a new pull request, #274:
URL: https://github.com/apache/incubator-uniffle/pull/274
### What changes were proposed in this pull request?
For issue#173, make the lifecycle of remoteStorage var scoped in the method of registerShuffle
### Why are the changes needed?
This problem causes getShuffleResult to fail, which eventually causes the task to fail.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston merged pull request #274: [ISSUE-273][BUG] Get shuffle result failed caused by concurrent calls to registerShuffle
Posted by GitBox <gi...@apache.org>.
zuston merged PR #274:
URL: https://github.com/apache/incubator-uniffle/pull/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #274: [ISSUE-273][BUG] Get shuffle result failed caused by concurrent calls to registerShuffle
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #274:
URL: https://github.com/apache/incubator-uniffle/pull/274#issuecomment-1286635518
I will back port this pr to 0.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #274: [ISSUE-273][BUG] Get shuffle result failed caused by concurrent calls to registerShuffle
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #274:
URL: https://github.com/apache/incubator-uniffle/pull/274#issuecomment-1286622676
Thanks for your contribution @leixm Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #274: [Bug] Get shuffle result failed caused by concurrent calls to registerShuffle
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #274:
URL: https://github.com/apache/incubator-uniffle/pull/274#issuecomment-1285651616
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#274](https://codecov.io/gh/apache/incubator-uniffle/pull/274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b941fb) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/7a2f0ef9ebca81b9d8eb4b2e643fb19331d1e944?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a2f0ef) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #274 +/- ##
=========================================
Coverage 59.71% 59.71%
Complexity 1377 1377
=========================================
Files 166 166
Lines 8918 8918
Branches 853 853
=========================================
Hits 5325 5325
Misses 3318 3318
Partials 275 275
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] leixm commented on pull request #274: [ISSUE-273][BUG] Get shuffle result failed caused by concurrent calls to registerShuffle
Posted by GitBox <gi...@apache.org>.
leixm commented on PR #274:
URL: https://github.com/apache/incubator-uniffle/pull/274#issuecomment-1286624443
@zuston Thank you for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #274: [ISSUE-273][Bug] Get shuffle result failed caused by concurrent calls to registerShuffle
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #274:
URL: https://github.com/apache/incubator-uniffle/pull/274#issuecomment-1286427499
This change is OK for me. Please update the spark3 client. @leixm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org