[ambari] branch trunk updated: AMBARI-23773. Suppress FindBugs warnings for EclipseLink-generated code (#1189)

[ad...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

adoroszlai pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ambari.git


The following commit(s) were added to refs/heads/trunk by this push:
     new ded5af3  AMBARI-23773. Suppress FindBugs warnings for EclipseLink-generated code (#1189)
ded5af3 is described below

commit ded5af32d569dbb46ed40d50e1d1313a0078b447
Author: Doroszlai, Attila <64...@users.noreply.github.com>
AuthorDate: Mon May 7 09:52:17 2018 +0200

    AMBARI-23773. Suppress FindBugs warnings for EclipseLink-generated code (#1189)
---
 ambari-server/findbugs.exclude.xml | 25 +++++++++++++++++++++++++
 ambari-server/pom.xml              |  4 ++++
 2 files changed, 29 insertions(+)

diff --git a/ambari-server/findbugs.exclude.xml b/ambari-server/findbugs.exclude.xml
new file mode 100644
index 0000000..74cd209
--- /dev/null
+++ b/ambari-server/findbugs.exclude.xml
@@ -0,0 +1,25 @@
+<?xml version="1.0"?>
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+<FindBugsFilter>
+  <Match>
+    <Class name="~.*Entity" />
+    <Method name="~_persistence_[gs]et" />
+    <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
+  </Match>
+</FindBugsFilter>
diff --git a/ambari-server/pom.xml b/ambari-server/pom.xml
index 8083880..cc82a6b 100644
--- a/ambari-server/pom.xml
+++ b/ambari-server/pom.xml
@@ -662,6 +662,7 @@
           <failOnError>false</failOnError>
           <threshold>Low</threshold>
           <findbugsXmlOutputDirectory>${project.basedir}/target/findbugs</findbugsXmlOutputDirectory>
+          <excludeFilterFile>${project.basedir}/findbugs.exclude.xml</excludeFilterFile>
         </configuration>
         <executions>
           <execution>
@@ -691,6 +692,9 @@
               <includes>
                 <include>*.xml</include>
               </includes>
+              <excludes>
+                <exclude>findbugs.exclude.xml</exclude>
+              </excludes>
               <outputDir>${project.basedir}/target/findbugs</outputDir>
               <stylesheet>fancy-hist.xsl</stylesheet>
               <fileMappers>

-- 
To stop receiving notification emails like this one, please contact
adoroszlai@apache.org.