You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/19 13:58:04 UTC
[GitHub] [airflow] brain-buster opened a new pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
brain-buster opened a new pull request #17082:
URL: https://github.com/apache/airflow/pull/17082
closes: #16976
Add json.dumps() for templated fields objects: 'dict' and 'list', which was existed in Apache Airflow version 2.0.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882570156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mehmax commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
mehmax commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-884718338
Hi, may I bring something up which I noticed while testing this:
When I use templated files in a _PythonVirtualenvDecoratedOperator, json.dumps will not add line breaks.
This is not very beautiful:
Example
Can we make it so that each key in a dictionary is rendered seperately? Like this (just an Idea):
Coding I used (no optimized!):
```
if renderer in renderers:
if isinstance(content, dict):
logging.info(content)
for key, value in content.items():
html_dict[key] = renderers[renderer](value)
if isinstance(content, list):
content = json.dumps(content, sort_keys=True, indent=4)
html_dict[template_field] = renderers[renderer](content)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-884935172
We actually had a discussion about it and we have proposal how to improve that. See #17032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-883631558
Should be easy to cherry-pick. Marked it as 2.1.3 provisionally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mehmax edited a comment on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
mehmax edited a comment on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-884718338
Hi, may I bring something up which I noticed while testing this:
When I use templated files in a _PythonVirtualenvDecoratedOperator and my file contains linebreaks, json.dumps will not add them in the UI.
This is not very beautiful:
Example
Can we make it so that each key in a dictionary is rendered seperately? Like this (just an Idea):
Coding I used (no optimized!):
```
if renderer in renderers:
if isinstance(content, dict):
logging.info(content)
for key, value in content.items():
html_dict[key] = renderers[renderer](value)
if isinstance(content, list):
content = json.dumps(content, sort_keys=True, indent=4)
html_dict[template_field] = renderers[renderer](content)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882775915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17082:
URL: https://github.com/apache/airflow/pull/17082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882775915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mehmax edited a comment on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
mehmax edited a comment on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-884718338
Hi, may I bring something up which I noticed while testing this:
When I use templated files in a _PythonVirtualenvDecoratedOperator and my file contains linebreaks, json.dumps will not add add them in the UI.
This is not very beautiful:
Example
Can we make it so that each key in a dictionary is rendered seperately? Like this (just an Idea):
Coding I used (no optimized!):
```
if renderer in renderers:
if isinstance(content, dict):
logging.info(content)
for key, value in content.items():
html_dict[key] = renderers[renderer](value)
if isinstance(content, list):
content = json.dumps(content, sort_keys=True, indent=4)
html_dict[template_field] = renderers[renderer](content)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] coolbeans201 commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
coolbeans201 commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882599735
Thanks for taking this on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] coolbeans201 commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
coolbeans201 commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882599735
Thanks for taking this on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882775915
I think it would be nice to add some unit tests for that one though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882798176
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882776204
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882570156
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vladm commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
vladm commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-883622713
Any chance this is pulled into next 2.1.X release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882776204
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] coolbeans201 commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
coolbeans201 commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882599735
Thanks for taking this on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17082:
URL: https://github.com/apache/airflow/pull/17082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882776204
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] brain-buster commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
brain-buster commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-883635047
> Should be easy to cherry-pick. Marked it as 2.1.3 provisionally
It will be awesome! Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882570156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17082:
URL: https://github.com/apache/airflow/pull/17082#issuecomment-882777466
Eh ..likely not worth it with the old UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17082: #16976 Add json.dumps() for templated fields objects: 'dict' and 'list'
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17082:
URL: https://github.com/apache/airflow/pull/17082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org