You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2023/03/09 17:34:32 UTC

[GitHub] [airflow] Taragolis commented on pull request #28970: Fix support for macros with dots in DataProcJobBuilder

Taragolis commented on PR #28970:
URL: https://github.com/apache/airflow/pull/28970#issuecomment-1462475656

   Sorry for late response. It is still unclear for me about this changes.
   
   I have a look on `DataProcJobBuilder` and it usage in `DataprocJobBaseOperator`, i could say that all operators which based on `DataprocJobBaseOperator`:
   1. Call [DataprocJobBaseOperator.create_job_template](https://airflow.apache.org/docs/apache-airflow-providers-google/stable/_modules/airflow/providers/google/cloud/operators/dataproc.html#DataprocJobBaseOperator.create_job_template) method in `execute`, so all templates should resolved at this point.
   2. Deprecated for very long time: https://github.com/apache/airflow/pull/6371, and recommendation is switch to [`DataprocSubmitJobOperator`](https://airflow.apache.org/docs/apache-airflow-providers-google/stable/operators/cloud/dataproc.html#submit-a-job-to-a-cluster) which do not use `DataProcJobBuilder` at all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org