You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jay Kreps <bo...@gmail.com> on 2014/02/21 06:36:15 UTC
Review Request 18344: Show per-topic configs in USAGE message for
kafka-topics.sh.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18344/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1276
https://issues.apache.org/jira/browse/KAFKA-1276
Repository: kafka
Description
-------
KAFKA-1276 Make topic command list the possible topic-level configs that are available.
Diffs
-----
core/src/main/scala/kafka/admin/TopicCommand.scala fc8d6861ccab54f9443c871b0208b81d172f357b
Diff: https://reviews.apache.org/r/18344/diff/
Testing
-------
Thanks,
Jay Kreps
Re: Review Request 18344: Show per-topic configs in USAGE message for
kafka-topics.sh.
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18344/#review35175
-----------------------------------------------------------
Ship it!
Just one minor comment.
core/src/main/scala/kafka/admin/TopicCommand.scala
<https://reviews.apache.org/r/18344/#comment65601>
In the output, the config option is not immediately above the delete-config option. Perhaps it's better to say "see the configurations listed in --config".
- Jun Rao
On Feb. 21, 2014, 5:36 a.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18344/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 5:36 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1276
> https://issues.apache.org/jira/browse/KAFKA-1276
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1276 Make topic command list the possible topic-level configs that are available.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/admin/TopicCommand.scala fc8d6861ccab54f9443c871b0208b81d172f357b
>
> Diff: https://reviews.apache.org/r/18344/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>