You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/07/30 20:24:02 UTC

[GitHub] jon-wei commented on a change in pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask

jon-wei commented on a change in pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask
URL: https://github.com/apache/incubator-druid/pull/6065#discussion_r206308816
 
 

 ##########
 File path: indexing-service/src/main/java/io/druid/indexing/common/task/IndexTask.java
 ##########
 @@ -416,6 +417,15 @@ public TaskStatus run(final TaskToolbox toolbox) throws Exception
         ((IngestSegmentFirehoseFactory) firehoseFactory).setTaskToolbox(toolbox);
       }
 
+      if (firehoseFactory instanceof CombiningFirehoseFactory) {
 
 Review comment:
   good point, made this recursive

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org