You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/30 08:29:57 UTC

[GitHub] [incubator-nuttx] no1wudi opened a new pull request, #6959: libc: Disable UBSan for allsyms_lookup

no1wudi opened a new pull request, #6959:
URL: https://github.com/apache/incubator-nuttx/pull/6959

   ## Summary
   * Add a new attribute nosanitize_undefined
   * Fix wrong report by design:
   ```
   ubsan_prologue: ================================================================================
   ubsan_prologue: UBSAN: array-index-out-of-bounds in symtab/symtab_allsyms.c:62:37
   __ubsan_handle_out_of_bounds: index 1619 is out of range for type 'symtab_s [1]'
   ubsan_epilogue: ================================================================================
   ```
   ## Impact
   libc only
   ## Testing
   Custom boards
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6959: libc: Fix wrong report by UBSan

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6959:
URL: https://github.com/apache/incubator-nuttx/pull/6959


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6959: libc: Disable UBSan for allsyms_lookup

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6959:
URL: https://github.com/apache/incubator-nuttx/pull/6959#discussion_r958178275


##########
libs/libc/symtab/symtab_allsyms.c:
##########
@@ -43,6 +43,7 @@ extern const int             g_nallsyms;
  *
  ****************************************************************************/
 
+nosanitize_undefined

Review Comment:
   let's change line 31 instead:
   extern const struct symtab_s g_allsyms[];



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org