You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Taragolis (via GitHub)" <gi...@apache.org> on 2023/02/21 12:34:45 UTC

[GitHub] [airflow] Taragolis commented on pull request #29635: YandexCloud provider: support Yandex SDK feature "endpoint"

Taragolis commented on PR #29635:
URL: https://github.com/apache/airflow/pull/29635#issuecomment-1438406620

   Looks nice, there are two things left
   1. Static Checks failed, I would recommend configure locally pre-commit hooks, see [Static code checks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#id4)
   2. Write unit tests for this new functional. If I were you i would have a look first in current [Yandex Cloud Hook Tests](https://github.com/apache/airflow/blob/bfcae349b88fd959e32bfacd027a5be976fe2132/tests/providers/yandex/hooks/test_yandex.py#L31). If for some reason you completely lost how to write tests cases feel free to join to [Airflow Slack](https://s.apache.org/airflow-slack) and ask around here, you could even try to ping me in DM, ifI have a time I would help you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org