You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "variantolog (via GitHub)" <gi...@apache.org> on 2026/06/29 14:01:43 UTC

[PR] Update terminal.c [guacamole-server]

variantolog opened a new pull request, #683:
URL: https://github.com/apache/guacamole-server/pull/683

   terminal.c: In function '__guac_terminal_send_key': terminal.c:1924:18: error: variable 'data' set but not used [-Werror=unused-but-set-variable]
    1924 |             char data;
         |                  ^~~~
   terminal.c:1967:51: error: 'data' undeclared (first use in this function)
    1967 |             return guac_terminal_send_data(term, &data, 1);
         |                                                   ^~~~
   terminal.c:1967:51: note: each undeclared identifier is reported only once for each function it appears in
   terminal.c:1829:13: error: suggest explicit braces to avoid ambiguous 'else' [-Werror=dangling-else]
    1829 |     else if (keysym == GUAC_TERMINAL_KEY_SHIFT_L || keysym == GUAC_TERMINAL_KEY_SHIFT_R)
         |             ^
   terminal.c: At top level:
   terminal.c:2193:5: error: expected identifier or '(' before 'return'
    2193 |     return 0;
         |     ^~~~~~
   terminal.c:2195:1: error: expected identifier or '(' before '}' token
    2195 | }
         | ^
   terminal.c: In function '__guac_terminal_send_key':
   terminal.c:2191:5: error: control reaches end of non-void function [-Werror=return-type]
    2191 |     }
         |     ^


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update terminal.c [guacamole-server]

Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper closed pull request #683: Update terminal.c
URL: https://github.com/apache/guacamole-server/pull/683


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update terminal.c [guacamole-server]

Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #683:
URL: https://github.com/apache/guacamole-server/pull/683#issuecomment-4836561667

   > @necouchman The origin of the issue seems to be related to the [Merge patch branch changes to main.](https://github.com/apache/guacamole-server/commit/805ffcfd9c4477c4fb982052b9d25b5cb3acd167) commit and the #505 MR that was in main, but not in patch, so those changes conflict with #637 .
   > 
   > This also seems to be the reason why the Jenkins build on main are failing, as pointed out on the mailing list.
   
   Yep, looks like I messed up the merge commit when pushing the changes from patch into main.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update terminal.c [guacamole-server]

Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #683:
URL: https://github.com/apache/guacamole-server/pull/683#issuecomment-4833625821

   Thanks, @variantolog - this pull request will need to either have a Jira issue created or be tagged with the Jira ticket that created the issue, likely the latest round of items that were merged into the `main` repo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update terminal.c [guacamole-server]

Posted by "lukasraska (via GitHub)" <gi...@apache.org>.
lukasraska commented on PR #683:
URL: https://github.com/apache/guacamole-server/pull/683#issuecomment-4836540533

   @necouchman The origin of the issue seems to be related to the [Merge patch branch changes to main.](https://github.com/apache/guacamole-server/commit/805ffcfd9c4477c4fb982052b9d25b5cb3acd167) commit and the https://github.com/apache/guacamole-server/pull/505 MR that was in main, but not in patch, so those changes conflict with https://github.com/apache/guacamole-server/pull/637 .
   
   This also seems to be the reason why the Jenkins build on main are failing, as pointed out on the mailing list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update terminal.c [guacamole-server]

Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #683:
URL: https://github.com/apache/guacamole-server/pull/683#issuecomment-4834460867

   @variantolog Additionally, this PR is failing to build:
   ```
   #20 16.10 terminal.c:2193:5: error: expected identifier or '(' before 'return'
   #20 16.10  2193 |     return 0;
   #20 16.10       |     ^~~~~~
   #20 16.10 terminal.c:2195:1: error: expected identifier or '(' before '}' token
   #20 16.10  2195 | }
   #20 16.10       | ^
   #20 16.12 terminal.c: In function '__guac_terminal_send_key':
   #20 16.12 terminal.c:2191:5: error: control reaches end of non-void function [-Werror=return-type]
   #20 16.12  2191 |     }
   #20 16.12       |     ^
   #20 16.12 terminal.c: At top level:
   #20 16.12 terminal.c:1773:12: error: '__guac_terminal_send_modified_function' defined but not used [-Werror=unused-function]
   #20 16.12  1773 | static int __guac_terminal_send_modified_function(guac_terminal* term, int keysym) {
   #20 16.12       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   #20 16.12 terminal.c:1724:12: error: '__guac_terminal_send_modified_editing' defined but not used [-Werror=unused-function]
   #20 16.12  1724 | static int __guac_terminal_send_modified_editing(guac_terminal* term, int keysym) {
   #20 16.12       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   #20 16.12 terminal.c:1637:12: error: '__guac_terminal_is_editing_keysym' defined but not used [-Werror=unused-function]
   #20 16.12  1637 | static int __guac_terminal_is_editing_keysym(int keysym) {
   #20 16.12       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   #20 16.13 terminal.c:1612:12: error: '__guac_terminal_is_function_keysym' defined but not used [-Werror=unused-function]
   #20 16.13  1612 | static int __guac_terminal_is_function_keysym(int keysym) {
   #20 16.13       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   #20 16.13 cc1: all warnings being treated as errors
   #20 16.13 make[3]: *** [Makefile:733: libguac_terminal_la-terminal.lo] Error 1
   #20 16.13 make[3]: *** Waiting for unfinished jobs....
   #20 16.33 make[3]: Leaving directory '/tmp/guacamole-server/src/terminal'
   #20 16.33 make[2]: *** [Makefile:801: all-recursive] Error 1
   #20 16.33 make[2]: Leaving directory '/tmp/guacamole-server/src/terminal'
   #20 16.33 make[1]: *** [Makefile:546: all-recursive] Error 1
   #20 16.33 make[1]: Leaving directory '/tmp/guacamole-server'
   #20 16.33 make: *** [Makefile:466: all] Error 2
   #20 ERROR: process "/bin/sh -c ${BUILD_DIR}/src/guacd-docker/bin/autobuild.sh \"GUACAMOLE_SERVER\" \"${BUILD_DIR}\"" did not complete successfully: exit code: 2
   ------
    > [guacamole-server 7/8] RUN /tmp/guacamole-server/src/guacd-docker/bin/autobuild.sh "GUACAMOLE_SERVER" "/tmp/guacamole-server":
   16.13       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   16.13 cc1: all warnings being treated as errors
   16.13 make[3]: *** [Makefile:733: libguac_terminal_la-terminal.lo] Error 1
   16.13 make[3]: *** Waiting for unfinished jobs....
   16.33 make[3]: Leaving directory '/tmp/guacamole-server/src/terminal'
   16.33 make[2]: *** [Makefile:801: all-recursive] Error 1
   16.33 make[2]: Leaving directory '/tmp/guacamole-server/src/terminal'
   16.33 make[1]: *** [Makefile:546: all-recursive] Error 1
   16.33 make[1]: Leaving directory '/tmp/guacamole-server'
   16.33 make: *** [Makefile:466: all] Error 2
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org