You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Ted Malaska <te...@cloudera.com> on 2015/07/01 23:01:25 UTC
Review Request 36105: FLUME-2729 : Allow pollableSource backoff times
to be configurable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36105/
-----------------------------------------------------------
Review request for Flume and Johny Rufus John.
Repository: flume-git
Description
-------
There are use cases that require more control of the backoff times setting. This jira will allow those times to be set through config of the source
Diffs
-----
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java 4e2f940
flume-ng-core/src/main/java/org/apache/flume/PollableSource.java e872b0c
flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java 356f4d4
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceConstants.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java f6c64b3
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 51e021a
flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 0e7020b
flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java 4d4222d
flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java c9d3e20
flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java 28270f4
flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java 3777639
Diff: https://reviews.apache.org/r/36105/diff/
Testing
-------
All existing test pass. I would like to add a new test that will confirm that values are read correctly from the config.
Thanks,
Ted Malaska
Re: Review Request 36105: FLUME-2729 : Allow pollableSource backoff
times to be configurable
Posted by Ted Malaska <te...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36105/
-----------------------------------------------------------
(Updated July 6, 2015, 12:50 a.m.)
Review request for Flume and Johny Rufus John.
Changes
-------
move import clean up
Repository: flume-git
Description
-------
There are use cases that require more control of the backoff times setting. This jira will allow those times to be set through config of the source
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java 4e2f940
flume-ng-core/src/main/java/org/apache/flume/PollableSource.java e872b0c
flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java 356f4d4
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceConstants.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java f6c64b3
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 51e021a
flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 0e7020b
flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java 02a2f0c
flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java 4d4222d
flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java c9d3e20
flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java 28270f4
flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java 3777639
Diff: https://reviews.apache.org/r/36105/diff/
Testing
-------
All existing test pass. I would like to add a new test that will confirm that values are read correctly from the config.
Thanks,
Ted Malaska
Re: Review Request 36105: FLUME-2729 : Allow pollableSource backoff
times to be configurable
Posted by Ted Malaska <te...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36105/
-----------------------------------------------------------
(Updated July 6, 2015, 12:48 a.m.)
Review request for Flume and Johny Rufus John.
Changes
-------
Cleaned up some extra spaces
Repository: flume-git
Description
-------
There are use cases that require more control of the backoff times setting. This jira will allow those times to be set through config of the source
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java 4e2f940
flume-ng-core/src/main/java/org/apache/flume/PollableSource.java e872b0c
flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java 356f4d4
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceConstants.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java f6c64b3
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 51e021a
flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 0e7020b
flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java 02a2f0c
flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java 4d4222d
flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java c9d3e20
flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java 28270f4
flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java 3777639
Diff: https://reviews.apache.org/r/36105/diff/
Testing
-------
All existing test pass. I would like to add a new test that will confirm that values are read correctly from the config.
Thanks,
Ted Malaska
Re: Review Request 36105: FLUME-2729 : Allow pollableSource backoff
times to be configurable
Posted by Ted Malaska <te...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36105/
-----------------------------------------------------------
(Updated July 6, 2015, 12:45 a.m.)
Review request for Flume and Johny Rufus John.
Changes
-------
Made changes based on Johny's comments
Repository: flume-git
Description
-------
There are use cases that require more control of the backoff times setting. This jira will allow those times to be set through config of the source
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java 4e2f940
flume-ng-core/src/main/java/org/apache/flume/PollableSource.java e872b0c
flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java 356f4d4
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceConstants.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java f6c64b3
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 51e021a
flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 0e7020b
flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java 02a2f0c
flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java 4d4222d
flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java c9d3e20
flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java 28270f4
flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java 3777639
Diff: https://reviews.apache.org/r/36105/diff/
Testing
-------
All existing test pass. I would like to add a new test that will confirm that values are read correctly from the config.
Thanks,
Ted Malaska
Re: Review Request 36105: FLUME-2729 : Allow pollableSource backoff
times to be configurable
Posted by Ted Malaska <te...@cloudera.com>.
> On July 4, 2015, 1:04 a.m., Johny Rufus John wrote:
> > +1, Looks good, very minor Nits
Done
> On July 4, 2015, 1:04 a.m., Johny Rufus John wrote:
> > flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java, line 25
> > <https://reviews.apache.org/r/36105/diff/3/?file=998333#file998333line25>
> >
> > Nit: Can we avoid .*
Done
> On July 4, 2015, 1:04 a.m., Johny Rufus John wrote:
> > flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java, line 36
> > <https://reviews.apache.org/r/36105/diff/3/?file=998333#file998333line36>
> >
> > Nit: Not needed to specify again - implements PollableSource and Configurable
Done
> On July 4, 2015, 1:04 a.m., Johny Rufus John wrote:
> > flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java, line 26
> > <https://reviews.apache.org/r/36105/diff/3/?file=998334#file998334line26>
> >
> > Nit: .* to be changed back
Done
> On July 4, 2015, 1:04 a.m., Johny Rufus John wrote:
> > flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java, line 56
> > <https://reviews.apache.org/r/36105/diff/3/?file=998334#file998334line56>
> >
> > Nit: Not needed to specify again - implements PollableSource and Configurable
Done
> On July 4, 2015, 1:04 a.m., Johny Rufus John wrote:
> > flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java, line 72
> > <https://reviews.apache.org/r/36105/diff/3/?file=998339#file998339line72>
> >
> > Not needed to specify implements Configurable and implements PollableSource
Done
- Ted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36105/#review90374
-----------------------------------------------------------
On July 2, 2015, 4:03 p.m., Ted Malaska wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36105/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 4:03 p.m.)
>
>
> Review request for Flume and Johny Rufus John.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> There are use cases that require more control of the backoff times setting. This jira will allow those times to be set through config of the source
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java 4e2f940
> flume-ng-core/src/main/java/org/apache/flume/PollableSource.java e872b0c
> flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java 356f4d4
> flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceConstants.java PRE-CREATION
> flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java f6c64b3
> flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 51e021a
> flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 0e7020b
> flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java 02a2f0c
> flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java 4d4222d
> flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java c9d3e20
> flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java 28270f4
> flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java 3777639
>
> Diff: https://reviews.apache.org/r/36105/diff/
>
>
> Testing
> -------
>
> All existing test pass. I would like to add a new test that will confirm that values are read correctly from the config.
>
>
> Thanks,
>
> Ted Malaska
>
>
Re: Review Request 36105: FLUME-2729 : Allow pollableSource backoff
times to be configurable
Posted by Johny Rufus John <jr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36105/#review90374
-----------------------------------------------------------
Ship it!
+1, Looks good, very minor Nits
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java (line 25)
<https://reviews.apache.org/r/36105/#comment143412>
Nit: Can we avoid .*
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java (line 33)
<https://reviews.apache.org/r/36105/#comment143413>
Nit: Not needed to specify again - implements PollableSource and Configurable
flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java (line 26)
<https://reviews.apache.org/r/36105/#comment143414>
Nit: .* to be changed back
flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java (line 51)
<https://reviews.apache.org/r/36105/#comment143415>
Nit: Not needed to specify again - implements PollableSource and Configurable
flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java (line 72)
<https://reviews.apache.org/r/36105/#comment143417>
Not needed to specify implements Configurable and implements PollableSource
- Johny Rufus John
On July 2, 2015, 4:03 p.m., Ted Malaska wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36105/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 4:03 p.m.)
>
>
> Review request for Flume and Johny Rufus John.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> There are use cases that require more control of the backoff times setting. This jira will allow those times to be set through config of the source
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java 4e2f940
> flume-ng-core/src/main/java/org/apache/flume/PollableSource.java e872b0c
> flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java 356f4d4
> flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceConstants.java PRE-CREATION
> flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java f6c64b3
> flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 51e021a
> flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 0e7020b
> flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java 02a2f0c
> flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java 4d4222d
> flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java c9d3e20
> flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java 28270f4
> flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java 3777639
>
> Diff: https://reviews.apache.org/r/36105/diff/
>
>
> Testing
> -------
>
> All existing test pass. I would like to add a new test that will confirm that values are read correctly from the config.
>
>
> Thanks,
>
> Ted Malaska
>
>
Re: Review Request 36105: FLUME-2729 : Allow pollableSource backoff
times to be configurable
Posted by Ted Malaska <te...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36105/
-----------------------------------------------------------
(Updated July 2, 2015, 4:03 p.m.)
Review request for Flume and Johny Rufus John.
Changes
-------
Removed spaces
Repository: flume-git
Description
-------
There are use cases that require more control of the backoff times setting. This jira will allow those times to be set through config of the source
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java 4e2f940
flume-ng-core/src/main/java/org/apache/flume/PollableSource.java e872b0c
flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java 356f4d4
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceConstants.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java f6c64b3
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 51e021a
flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 0e7020b
flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java 02a2f0c
flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java 4d4222d
flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java c9d3e20
flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java 28270f4
flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java 3777639
Diff: https://reviews.apache.org/r/36105/diff/
Testing
-------
All existing test pass. I would like to add a new test that will confirm that values are read correctly from the config.
Thanks,
Ted Malaska
Re: Review Request 36105: FLUME-2729 : Allow pollableSource backoff
times to be configurable
Posted by Ted Malaska <te...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36105/
-----------------------------------------------------------
(Updated July 2, 2015, 4:01 p.m.)
Review request for Flume and Johny Rufus John.
Changes
-------
Added unit test and cleaned up diff
Repository: flume-git
Description
-------
There are use cases that require more control of the backoff times setting. This jira will allow those times to be set through config of the source
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java 4e2f940
flume-ng-core/src/main/java/org/apache/flume/PollableSource.java e872b0c
flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java 356f4d4
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceConstants.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java f6c64b3
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 51e021a
flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java 0e7020b
flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java 02a2f0c
flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java 4d4222d
flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java c9d3e20
flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java 28270f4
flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java 3777639
Diff: https://reviews.apache.org/r/36105/diff/
Testing
-------
All existing test pass. I would like to add a new test that will confirm that values are read correctly from the config.
Thanks,
Ted Malaska