You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Volkan Yazıcı <vo...@yazi.ci> on 2022/11/07 21:03:12 UTC
Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
In the context of migrating away from JIRA to GitHub Issues, I want to
replace the current maven-changes-plugin setup with a merge-conflict-free
Markdown-based solution. I have elaborated the details in LOG4J2-3628
<https://issues.apache.org/jira/browse/LOG4J2-3628>.
Since this will change the behaviour of how we introduce changes and make
releases, I would appreciate it if committers could skim through it and
share their feedback.
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Gary Gregory <ga...@gmail.com>.
I've used XInclude in the past at work and in some FOSS projects and it
works great.
The wrinkle is to guard against what is included to avoid CVEs. Same issue
with DTDs.
Gary
On Thu, Nov 10, 2022, 13:40 Ralph Goers <ra...@dslextreme.com> wrote:
> I’ve suggested to Volkan that he look to see if the changes plugin
> supports XIncludes in changes.xml and if it doesn’t how much work it would
> be to add it.
>
> Ralph
>
> > On Nov 10, 2022, at 10:36 AM, Matt Sicker <ma...@musigma.org> wrote:
> >
> > It’s manual work that makes merging PRs non-trivial.
> >
> >> On Nov 9, 2022, at 10:58 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
> >>
> >> It is, but it isn’t one of the items that I personally consider broken.
> >>
> >> Ralph
> >>
> >>> On Nov 9, 2022, at 3:50 PM, Matt Sicker <ma...@musigma.org> wrote:
> >>>
> >>> The changelog is an important aspect of the website, too.
> >>>
> >>>> On Nov 9, 2022, at 1:43 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
> >>>>
> >>>> See my comments in the issue. I’d rather focus on web site changes
> that provide real value.
> >>>>
> >>>> Ralph
> >>>>
> >>>>> On Nov 8, 2022, at 3:41 PM, Gary Gregory <ga...@gmail.com>
> wrote:
> >>>>>
> >>>>> I do like all the details in the Jira ticket! :-)
> >>>>>
> >>>>> Gary
> >>>>>
> >>>>> On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı <vo...@yazi.ci> wrote:
> >>>>>
> >>>>>> In the context of migrating away from JIRA to GitHub Issues, I want
> to
> >>>>>> replace the current maven-changes-plugin setup with a
> merge-conflict-free
> >>>>>> Markdown-based solution. I have elaborated the details in
> LOG4J2-3628
> >>>>>> <https://issues.apache.org/jira/browse/LOG4J2-3628>.
> >>>>>>
> >>>>>> Since this will change the behaviour of how we introduce changes
> and make
> >>>>>> releases, I would appreciate it if committers could skim through it
> and
> >>>>>> share their feedback.
> >>>>>>
> >>>>
> >>>
> >>
> >
>
>
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Ralph Goers <ra...@dslextreme.com>.
I’ve suggested to Volkan that he look to see if the changes plugin supports XIncludes in changes.xml and if it doesn’t how much work it would be to add it.
Ralph
> On Nov 10, 2022, at 10:36 AM, Matt Sicker <ma...@musigma.org> wrote:
>
> It’s manual work that makes merging PRs non-trivial.
>
>> On Nov 9, 2022, at 10:58 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>
>> It is, but it isn’t one of the items that I personally consider broken.
>>
>> Ralph
>>
>>> On Nov 9, 2022, at 3:50 PM, Matt Sicker <ma...@musigma.org> wrote:
>>>
>>> The changelog is an important aspect of the website, too.
>>>
>>>> On Nov 9, 2022, at 1:43 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>
>>>> See my comments in the issue. I’d rather focus on web site changes that provide real value.
>>>>
>>>> Ralph
>>>>
>>>>> On Nov 8, 2022, at 3:41 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>
>>>>> I do like all the details in the Jira ticket! :-)
>>>>>
>>>>> Gary
>>>>>
>>>>> On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı <vo...@yazi.ci> wrote:
>>>>>
>>>>>> In the context of migrating away from JIRA to GitHub Issues, I want to
>>>>>> replace the current maven-changes-plugin setup with a merge-conflict-free
>>>>>> Markdown-based solution. I have elaborated the details in LOG4J2-3628
>>>>>> <https://issues.apache.org/jira/browse/LOG4J2-3628>.
>>>>>>
>>>>>> Since this will change the behaviour of how we introduce changes and make
>>>>>> releases, I would appreciate it if committers could skim through it and
>>>>>> share their feedback.
>>>>>>
>>>>
>>>
>>
>
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Matt Sicker <ma...@musigma.org>.
It’s manual work that makes merging PRs non-trivial.
> On Nov 9, 2022, at 10:58 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>
> It is, but it isn’t one of the items that I personally consider broken.
>
> Ralph
>
>> On Nov 9, 2022, at 3:50 PM, Matt Sicker <ma...@musigma.org> wrote:
>>
>> The changelog is an important aspect of the website, too.
>>
>>> On Nov 9, 2022, at 1:43 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>
>>> See my comments in the issue. I’d rather focus on web site changes that provide real value.
>>>
>>> Ralph
>>>
>>>> On Nov 8, 2022, at 3:41 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>
>>>> I do like all the details in the Jira ticket! :-)
>>>>
>>>> Gary
>>>>
>>>> On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı <vo...@yazi.ci> wrote:
>>>>
>>>>> In the context of migrating away from JIRA to GitHub Issues, I want to
>>>>> replace the current maven-changes-plugin setup with a merge-conflict-free
>>>>> Markdown-based solution. I have elaborated the details in LOG4J2-3628
>>>>> <https://issues.apache.org/jira/browse/LOG4J2-3628>.
>>>>>
>>>>> Since this will change the behaviour of how we introduce changes and make
>>>>> releases, I would appreciate it if committers could skim through it and
>>>>> share their feedback.
>>>>>
>>>
>>
>
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Ralph Goers <ra...@dslextreme.com>.
It is, but it isn’t one of the items that I personally consider broken.
Ralph
> On Nov 9, 2022, at 3:50 PM, Matt Sicker <ma...@musigma.org> wrote:
>
> The changelog is an important aspect of the website, too.
>
>> On Nov 9, 2022, at 1:43 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>
>> See my comments in the issue. I’d rather focus on web site changes that provide real value.
>>
>> Ralph
>>
>>> On Nov 8, 2022, at 3:41 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>> I do like all the details in the Jira ticket! :-)
>>>
>>> Gary
>>>
>>> On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı <vo...@yazi.ci> wrote:
>>>
>>>> In the context of migrating away from JIRA to GitHub Issues, I want to
>>>> replace the current maven-changes-plugin setup with a merge-conflict-free
>>>> Markdown-based solution. I have elaborated the details in LOG4J2-3628
>>>> <https://issues.apache.org/jira/browse/LOG4J2-3628>.
>>>>
>>>> Since this will change the behaviour of how we introduce changes and make
>>>> releases, I would appreciate it if committers could skim through it and
>>>> share their feedback.
>>>>
>>
>
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Matt Sicker <ma...@musigma.org>.
The changelog is an important aspect of the website, too.
> On Nov 9, 2022, at 1:43 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>
> See my comments in the issue. I’d rather focus on web site changes that provide real value.
>
> Ralph
>
>> On Nov 8, 2022, at 3:41 PM, Gary Gregory <ga...@gmail.com> wrote:
>>
>> I do like all the details in the Jira ticket! :-)
>>
>> Gary
>>
>> On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı <vo...@yazi.ci> wrote:
>>
>>> In the context of migrating away from JIRA to GitHub Issues, I want to
>>> replace the current maven-changes-plugin setup with a merge-conflict-free
>>> Markdown-based solution. I have elaborated the details in LOG4J2-3628
>>> <https://issues.apache.org/jira/browse/LOG4J2-3628>.
>>>
>>> Since this will change the behaviour of how we introduce changes and make
>>> releases, I would appreciate it if committers could skim through it and
>>> share their feedback.
>>>
>
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Ralph Goers <ra...@dslextreme.com>.
See my comments in the issue. I’d rather focus on web site changes that provide real value.
Ralph
> On Nov 8, 2022, at 3:41 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> I do like all the details in the Jira ticket! :-)
>
> Gary
>
> On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı <vo...@yazi.ci> wrote:
>
>> In the context of migrating away from JIRA to GitHub Issues, I want to
>> replace the current maven-changes-plugin setup with a merge-conflict-free
>> Markdown-based solution. I have elaborated the details in LOG4J2-3628
>> <https://issues.apache.org/jira/browse/LOG4J2-3628>.
>>
>> Since this will change the behaviour of how we introduce changes and make
>> releases, I would appreciate it if committers could skim through it and
>> share their feedback.
>>
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Gary Gregory <ga...@gmail.com>.
I do like all the details in the Jira ticket! :-)
Gary
On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı <vo...@yazi.ci> wrote:
> In the context of migrating away from JIRA to GitHub Issues, I want to
> replace the current maven-changes-plugin setup with a merge-conflict-free
> Markdown-based solution. I have elaborated the details in LOG4J2-3628
> <https://issues.apache.org/jira/browse/LOG4J2-3628>.
>
> Since this will change the behaviour of how we introduce changes and make
> releases, I would appreciate it if committers could skim through it and
> share their feedback.
>
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Carter Kozak <ck...@ckozak.net>.
On Tue, Nov 8, 2022, at 14:28, Matt Sicker wrote:
> Any bug tracker we use which isn’t hosted by Apache will likely have similar issues.
The Apache Jira instance has the same issue at this point, even more broadly. I agree that the mailing list is a reasonable option for folks to report issues. If the existing user or dev lists become inundated with bug reports, we can always spin up a new mailing list for tracking and triage, but I suspect that will be the exception rather than the rule.
Carter Kozak
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Matt Sicker <ma...@musigma.org>.
This is why I’ve suggested accepting bug reports via email in addition to GitHub. Any bug tracker we use which isn’t hosted by Apache will likely have similar issues.
> On Nov 7, 2022, at 8:58 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> Just FYI,
>
> There is a release note discussion going on on the Maven list and someone
> said the following when I mentioned our plan to switch to GitHub Issues:
>
> "So you mean using ONLY gh for issues?
> So by doing this, you will exclude people living in countries banned
> from Github.
> Is it acceptable from an Apache Foundation POV?"
>
> Gary
>
> On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı <vo...@yazi.ci> wrote:
>
>> In the context of migrating away from JIRA to GitHub Issues, I want to
>> replace the current maven-changes-plugin setup with a merge-conflict-free
>> Markdown-based solution. I have elaborated the details in LOG4J2-3628
>> <https://issues.apache.org/jira/browse/LOG4J2-3628>.
>>
>> Since this will change the behaviour of how we introduce changes and make
>> releases, I would appreciate it if committers could skim through it and
>> share their feedback.
>>
Re: Review Request: LOG4J2-3628 Migrate from maven-changes-plugin to a merge-conflict-free Markdown-based solution
Posted by Gary Gregory <ga...@gmail.com>.
Just FYI,
There is a release note discussion going on on the Maven list and someone
said the following when I mentioned our plan to switch to GitHub Issues:
"So you mean using ONLY gh for issues?
So by doing this, you will exclude people living in countries banned
from Github.
Is it acceptable from an Apache Foundation POV?"
Gary
On Mon, Nov 7, 2022, 16:03 Volkan Yazıcı <vo...@yazi.ci> wrote:
> In the context of migrating away from JIRA to GitHub Issues, I want to
> replace the current maven-changes-plugin setup with a merge-conflict-free
> Markdown-based solution. I have elaborated the details in LOG4J2-3628
> <https://issues.apache.org/jira/browse/LOG4J2-3628>.
>
> Since this will change the behaviour of how we introduce changes and make
> releases, I would appreciate it if committers could skim through it and
> share their feedback.
>