You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2015/11/22 08:14:55 UTC

[GitHub] incubator-zeppelin pull request: ZEPPELIN-455 Improve build instru...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/459

    ZEPPELIN-455 Improve build instruction

    This PR improves build instruction in README.md
    https://issues.apache.org/jira/browse/ZEPPELIN-455

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/incubator-zeppelin ZEPPELIN-455

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #459
    
----
commit 777599d6df427ef671b367c9b413485d45fa868c
Author: Lee moon soo <mo...@apache.org>
Date:   2015-11-22T07:14:14Z

    Improve build instruction

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-455 Improve build instru...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/459#issuecomment-158735926
  
    Looks great to me.
    Do we mention all interpreters here or only those who mandatory require a build-time flags? (i.e Flink is not here) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-455 Improve build instru...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/459#issuecomment-158851422
  
    looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-zeppelin pull request: ZEPPELIN-455 Improve build instru...

Posted by Alex <ke...@gmail.com>.
Makes perfect sence, thank you!

On Sun, Nov 22, 2015, 18:59 Leemoonsoo <gi...@git.apache.org> wrote:

> Github user Leemoonsoo commented on the pull request:
>
>
> https://github.com/apache/incubator-zeppelin/pull/459#issuecomment-158742143
>
>     Thanks. While 'Build from source' section on the [install page](
> http://zeppelin.incubator.apache.org/docs/0.5.5-incubating/install/install.html)
> points README.md, it is good to list if any interpreter has build flag that
> user should aware. But i think if there're no special option to configure
> in build-time, no reason to mention.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] incubator-zeppelin pull request: ZEPPELIN-455 Improve build instru...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/459#issuecomment-158742143
  
    Thanks. While 'Build from source' section on the [install page](http://zeppelin.incubator.apache.org/docs/0.5.5-incubating/install/install.html) points README.md, it is good to list if any interpreter has build flag that user should aware. But i think if there're no special option to configure in build-time, no reason to mention.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-455 Improve build instru...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/459#issuecomment-158911153
  
    Merge if there're no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-455 Improve build instru...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/459


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---