You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/05/16 11:19:46 UTC
[GitHub] [qpid-proton] jiridanek opened a new pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
jiridanek opened a new pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313
Not immediately useful in Proton. This is to keep the module in sync with Dispatch code where it is duplicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313#issuecomment-841817596
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#313](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b776e4) into [main](https://codecov.io/gh/apache/qpid-proton/commit/8c0f6689521185d8825d89a984e3aae9f577fb2c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c0f668) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 47 47
Lines 2394 2394
=======================================
Hits 2115 2115
Misses 279 279
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8c0f668...8b776e4](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek merged pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter commented on pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313#issuecomment-841817596
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#313](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b776e4) into [main](https://codecov.io/gh/apache/qpid-proton/commit/8c0f6689521185d8825d89a984e3aae9f577fb2c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c0f668) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 47 47
Lines 2394 2394
=======================================
Hits 2115 2115
Misses 279 279
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8c0f668...8b776e4](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313#issuecomment-843317700
Thinking about this, I think that Proton should require Python 3.6.8 in the CMakeLists. It's true that the bindings can be built just fine when only Python 2 is available, but 1) it's limiting --- some python scripts have to stay py2 compatible and it is necessary to keep track of which is which 2) it makes it easier for the users who want to use the Python binding; Proton will pick up the compatible python by default (on systems where both 2 and 3 are available).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter commented on pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313#issuecomment-841817596
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#313](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b776e4) into [main](https://codecov.io/gh/apache/qpid-proton/commit/8c0f6689521185d8825d89a984e3aae9f577fb2c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c0f668) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 47 47
Lines 2394 2394
=======================================
Hits 2115 2115
Misses 279 279
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8c0f668...8b776e4](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on a change in pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
astitcher commented on a change in pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313#discussion_r636153323
##########
File path: CMakeLists.txt
##########
@@ -42,7 +42,7 @@ endif ()
if (NOT DEFINED Python_FIND_FRAMEWORK)
set(Python_FIND_FRAMEWORK "LAST")
endif ()
-find_package(Python
+find_package(Python 3.6.8
Review comment:
Just 3.6 is consistent with are stated requirements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313#issuecomment-841817596
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#313](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a8b730) into [main](https://codecov.io/gh/apache/qpid-proton/commit/8c0f6689521185d8825d89a984e3aae9f577fb2c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c0f668) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 5a8b730 differs from pull request most recent head 449a114. Consider uploading reports for the commit 449a114 to get more accurate results
[](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 47 47
Lines 2394 2394
=======================================
Hits 2115 2115
Misses 279 279
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8c0f668...449a114](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313#issuecomment-841817596
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#313](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b776e4) into [main](https://codecov.io/gh/apache/qpid-proton/commit/8c0f6689521185d8825d89a984e3aae9f577fb2c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c0f668) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 47 47
Lines 2394 2394
=======================================
Hits 2115 2115
Misses 279 279
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8c0f668...8b776e4](https://codecov.io/gh/apache/qpid-proton/pull/313?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek edited a comment on pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
jiridanek edited a comment on pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313#issuecomment-843317700
Thinking about this, I think that Proton should require Python 3.6.8 in the CMakeLists. It's true that the (other) bindings can be built just fine when only Python 2 is available, but 1) it's limiting --- some python scripts have to stay py2 compatible and it is necessary to keep track of which is which 2) it makes it easier for the users who want to use the Python binding; Proton will pick up the compatible python by default (on systems where both 2 and 3 are available).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on a change in pull request #313: PROTON-2323 Propagate requested version from FindPython to FindPythonInterp
Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #313:
URL: https://github.com/apache/qpid-proton/pull/313#discussion_r636157472
##########
File path: CMakeLists.txt
##########
@@ -42,7 +42,7 @@ endif ()
if (NOT DEFINED Python_FIND_FRAMEWORK)
set(Python_FIND_FRAMEWORK "LAST")
endif ()
-find_package(Python
+find_package(Python 3.6.8
Review comment:
```suggestion
find_package(Python 3.6
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org