You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Mike Percy (Created) (JIRA)" <ji...@apache.org> on 2012/04/19 00:12:39 UTC
[jira] [Created] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
flume-ng script bad ordering on FLUME_HOME var
----------------------------------------------
Key: FLUME-1130
URL: https://issues.apache.org/jira/browse/FLUME-1130
Project: Flume
Issue Type: Bug
Reporter: Mike Percy
Assignee: Mike Percy
Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257121#comment-13257121 ]
Hudson commented on FLUME-1130:
-------------------------------
Integrated in flume-trunk #176 (See [https://builds.apache.org/job/flume-trunk/176/])
FLUME-1130: flume-ng script bad ordering on FLUME_HOME var
(Mike Percy via Brock Noland) (Revision 1327720)
Result = SUCCESS
brock : http://svn.apache.org/viewvc/?view=rev&rev=1327720
Files :
* /incubator/flume/trunk/bin/flume-ng
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257052#comment-13257052 ]
jiraposter@reviews.apache.org commented on FLUME-1130:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4795/#review7010
-----------------------------------------------------------
Ship it!
Thanks, just hit this myself! Please attach the patch to the jira.
- Brock
On 2012-04-18 22:49:22, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4795/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-18 22:49:22)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. regression refers to FLUME_HOME before it's defined.
bq.
bq.
bq. This addresses bug FLUME-1130.
bq. https://issues.apache.org/jira/browse/FLUME-1130
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng 255cadd
bq.
bq. Diff: https://reviews.apache.org/r/4795/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Basic startup works again.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1130:
--------------------------------
Fix Version/s: v1.2.0
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1130:
------------------------------
Status: Patch Available (was: Open)
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1130:
------------------------------
Status: Patch Available (was: Reopened)
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1130-1.patch, FLUME-1130-2.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1130:
------------------------------
Attachment: FLUME-1130-1.patch
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257201#comment-13257201 ]
jiraposter@reviews.apache.org commented on FLUME-1130:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4795/
-----------------------------------------------------------
(Updated 2012-04-19 04:00:02.087300)
Review request for Flume.
Changes
-------
Since the first patch has already been committed, the 2nd patch applies on top of the first one.
We need to allow scripts to define FLUME_HOME as an environment variable (even though environment variables are invisible and hard to debug) in order to support init scripts easily. This is one case where avoiding env vars and requiring everything to be defined in CONF/flume-env.sh is not a good answer.
Summary
-------
regression refers to FLUME_HOME before it's defined.
This addresses bug FLUME-1130.
https://issues.apache.org/jira/browse/FLUME-1130
Diffs (updated)
-----
bin/flume-ng 39f6b05
Diff: https://reviews.apache.org/r/4795/diff
Testing
-------
Basic startup works again.
Thanks,
Mike
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257050#comment-13257050 ]
jiraposter@reviews.apache.org commented on FLUME-1130:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4795/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
regression refers to FLUME_HOME before it's defined.
This addresses bug FLUME-1130.
https://issues.apache.org/jira/browse/FLUME-1130
Diffs
-----
bin/flume-ng 255cadd
Diff: https://reviews.apache.org/r/4795/diff
Testing
-------
Basic startup works again.
Thanks,
Mike
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Mike Percy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1130:
------------------------------
Attachment: FLUME-1130-2.patch
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1130-1.patch, FLUME-1130-2.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1130:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed in 1328996.
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1130-1.patch, FLUME-1130-2.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257063#comment-13257063 ]
jiraposter@reviews.apache.org commented on FLUME-1130:
------------------------------------------------------
bq. On 2012-04-18 22:50:56, Brock Noland wrote:
bq. > Thanks, just hit this myself! Please attach the patch to the jira.
Done, thanks Brock!
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4795/#review7010
-----------------------------------------------------------
On 2012-04-18 22:49:22, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4795/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-18 22:49:22)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. regression refers to FLUME_HOME before it's defined.
bq.
bq.
bq. This addresses bug FLUME-1130.
bq. https://issues.apache.org/jira/browse/FLUME-1130
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng 255cadd
bq.
bq. Diff: https://reviews.apache.org/r/4795/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Basic startup works again.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Mike Percy (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy reopened FLUME-1130:
-------------------------------
Ugh, I thought I was being clever by forcing FLUME_HOME to be passed in via flume-env.sh but it broke BIGTOP init scripts. Trying again.
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257876#comment-13257876 ]
jiraposter@reviews.apache.org commented on FLUME-1130:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4795/#review7050
-----------------------------------------------------------
Ship it!
Please attach the patch to the JIRA.
- Brock
On 2012-04-19 04:00:02, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4795/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-19 04:00:02)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. regression refers to FLUME_HOME before it's defined.
bq.
bq.
bq. This addresses bug FLUME-1130.
bq. https://issues.apache.org/jira/browse/FLUME-1130
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng 39f6b05
bq.
bq. Diff: https://reviews.apache.org/r/4795/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Basic startup works again.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259379#comment-13259379 ]
Hudson commented on FLUME-1130:
-------------------------------
Integrated in flume-trunk #178 (See [https://builds.apache.org/job/flume-trunk/178/])
FLUME-1130: flume-ng script bad ordering on FLUME_HOME var
(Mike Percy via Brock Noland) (Revision 1328996)
Result = SUCCESS
brock : http://svn.apache.org/viewvc/?view=rev&rev=1328996
Files :
* /incubator/flume/trunk/bin/flume-ng
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
> Attachments: FLUME-1130-1.patch, FLUME-1130-2.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1130) flume-ng script bad ordering on
FLUME_HOME var
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-1130:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed in 1327720.
Thank you for your patch Mike!
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
> Key: FLUME-1130
> URL: https://issues.apache.org/jira/browse/FLUME-1130
> Project: Flume
> Issue Type: Bug
> Reporter: Mike Percy
> Assignee: Mike Percy
> Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME referenced before being defined).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira