You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jeffrey Schroeder <je...@computer.org> on 2015/01/24 22:48:31 UTC

Review Request 30248: Fix a markdown syntax error in the deployment docs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30248/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

Fix a markdown syntax error in the deployment docs


Diffs
-----

  docs/deploying-aurora-scheduler.md c14f865a844b6eb34cc0e9363dba50d4975f5632 

Diff: https://reviews.apache.org/r/30248/diff/


Testing
-------

Rendered document before and then after.


Thanks,

Jeffrey Schroeder


Re: Review Request 30248: Fix a markdown syntax error in the deployment docs

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30248/#review69549
-----------------------------------------------------------


Master (7ba6226) is red with this patch.
  ./build-support/jenkins/build.sh

:assemble
:compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7'
1 warning

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdMain
:test
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage of 0.8916830111142243 exceeds minimum coverage of 0.89.
:analyzeReport FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':analyzeReport'.
> Branch coverage is 0.8336745138178097, but must be greater than 0.835

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 3 mins 33.626 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 24, 2015, 9:48 p.m., Jeffrey Schroeder wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30248/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 9:48 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix a markdown syntax error in the deployment docs
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md c14f865a844b6eb34cc0e9363dba50d4975f5632 
> 
> Diff: https://reviews.apache.org/r/30248/diff/
> 
> 
> Testing
> -------
> 
> Rendered document before and then after.
> 
> 
> Thanks,
> 
> Jeffrey Schroeder
> 
>


Re: Review Request 30248: Fix a markdown syntax error in the deployment docs

Posted by Dave Lester <dl...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30248/#review69620
-----------------------------------------------------------



docs/deploying-aurora-scheduler.md
<https://reviews.apache.org/r/30248/#comment114340>

    Nice catch. Could you also correct the link here? It should `monitoring.md` vs `docs/monitoring.md`


- Dave Lester


On Jan. 24, 2015, 9:48 p.m., Jeffrey Schroeder wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30248/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2015, 9:48 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix a markdown syntax error in the deployment docs
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md c14f865a844b6eb34cc0e9363dba50d4975f5632 
> 
> Diff: https://reviews.apache.org/r/30248/diff/
> 
> 
> Testing
> -------
> 
> Rendered document before and then after.
> 
> 
> Thanks,
> 
> Jeffrey Schroeder
> 
>