[GitHub] [carbondata] ravipesala commented on a change in pull request #3313: Setting Spark Execution Id to null only for Spark version 2.2 and below.

[GitBox <gi...@apache.org>]

ravipesala commented on a change in pull request #3313: Setting Spark Execution Id to null only for Spark version 2.2 and below.
URL: https://github.com/apache/carbondata/pull/3313#discussion_r299538367
 
 

 ##########
 File path: integration/spark-datasource/src/main/scala/org/apache/spark/util/SparkUtil.scala
 ##########
 @@ -57,4 +59,12 @@ object SparkUtil {
     isSparkVersionXandAbove(xVersion, true)
   }
 
+  // "spark.sql.execution.id is already set" exception will be
+  // thrown if not set to null in spark2.2 and below versions
+  def setSparkExecutionId(sparkSession: SparkSession, executionId: String): Unit = {
 
 Review comment:
   just name the method name as `setNullExecutionId` and don't pass the `executionId` to it. Handle inside the method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services