You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/01/05 10:37:30 UTC

[GitHub] zeppelin pull request #1849: [ZEPPELIN-1902] Fix blank default intp select b...

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/1849

    [ZEPPELIN-1902] Fix blank default intp select box after Zeppelin started when Shiro on

    ### What is this PR for?
    After #1520 we can set default interpreter when we create new note. Currently this feature is implemented to get `interpreterSetting` list when Zeppelin is initiated (can be checked in dev console). And it needs user's info. So there can be two cases like below.
    
     - Shiro off 
    It tries to get interpreter setting lists as `anonymous` user
    ![shirooff](https://cloud.githubusercontent.com/assets/10060731/21676394/cce513d8-d378-11e6-9645-99255882b664.png)
    In this case, the problem is not happened. If we don't turn Shiro on, it doesn't need user's info and Zeppelin automatically creates fake user(?) info as `anonymous`. So there is no problem to get the interpreter setting lists. 
    
     - Shiro on
    tries to get interpreter setting lists as '  ' user since we're not loggined yet. 
    ![shiroon](https://cloud.githubusercontent.com/assets/10060731/21676414/db03515a-d378-11e6-99c9-34775e07a2e8.png) 
    So it's failed to get interpreter setting lists since it doesn't have any user info. It needs reloading to get it. 
    ![whenshiroon](https://cloud.githubusercontent.com/assets/10060731/21676657/e08ee03e-d379-11e6-8844-6baa673e0308.gif)
    
    
    Actually we don't need to send `GET_INTERPRETER_SETTINGS` msg when Zeppelin started. It would be fine when we click "Create new note" button. So I removed `init()` (it's used only for getting interpreter settings) and made `getInterpreterSettings` called only when user clicks "Create new note" in both Zeppelin home and Navbar. 
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1902](https://issues.apache.org/jira/browse/ZEPPELIN-1902)
    
    ### How should this be tested?
    In master (not this branch)
    1. [Turn Shiro on](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shiroauthentication.html#1-enable-shiro) and start(restart) Zeppelin 
    2. Click "Create new note" in home (or Navbar)
    3. the default interpreter select box will be like 
    ![screen shot 2017-01-05 at 7 16 08 pm](https://cloud.githubusercontent.com/assets/10060731/21676986/7a005a80-d37b-11e6-80d9-1597914c4b05.png)
    
    but it'll be okay after reloading. It shouldn't be like that with this patch. 
    
    
    ### Screenshots (if appropriate)
    after fixing this problem
    ![whenshiroonafter](https://cloud.githubusercontent.com/assets/10060731/21676678/08a2360c-d37a-11e6-9a9b-03457b88a4fb.gif)
     
    
    ### Questions:
    * Does the licenses files need update? no 
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1902

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1849.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1849
    
----
commit a321ba72958d61c3f7694913b48c80f2f797475d
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2017-01-05T09:40:23Z

    Fix interpreterSettings list showing up issue when Shiro off

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1849: [ZEPPELIN-1902] Fix blank default intp select b...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1849


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---