You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@apache.org> on 2019/03/21 22:43:49 UTC
[VOTE] Release 4.9.1, release candidate #0
Hi everyone,
Please review and vote on the release candidate #0 for the version
4.9.1, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* Release notes [1]
* The official Apache source and binary distributions to be deployed
to dist.apache.org [2]
* All artifacts to be deployed to the Maven Central Repository [3]
* Source code tag "v4.9.1-rc0" [4] with git sha
c053b81be43845122a0627f12e1cf7e08330a3c5
BookKeeper's KEYS file contains PGP keys we used to sign this release:
https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
Please download these packages and review this release candidate:
- Review release notes
- Download the source package (verify shasum, and asc) and follow the
instructions to build and run the bookkeeper service.
- Download the binary package (verify shasum, and asc) and follow the
instructions to run the bookkeeper service.
- Review maven repo, release tag, licenses, and any other things you think
it is important to a release.
The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
Thanks,
Enrico Olivelli
[1] https://github.com/apache/bookkeeper/pull/1992/commits/e24b8f98c0c435a0bba9dda0e4c37d9e88107187
[2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.9.1-rc0/
[3] https://repository.apache.org/content/repositories/orgapachebookkeeper-1040/
[4] https://github.com/apache/bookkeeper/tree/v4.9.1-rc0
Re: [VOTE] Release 4.9.1, release candidate #0
Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
verified checksums and signtures
built with JDK 8 from stage sources
not blocker: we should update Copyright in NOTICE with 2019 (not it is 2018)
not blocker: I had problems with a clean build with JDK11
I am sure BK is working on Java 11 in production, it is only a matter
of Maven configuration, filed an issue:
https://github.com/apache/bookkeeper/issues/2062
Enrico
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29.880 s
[INFO] Finished at: 2019-04-05T08:51:39+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar
(attach-javadocs) on project bookkeeper-stats-api:
MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1 - javadoc: error - The code being documented uses
modules but the packages defined in
https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR]
[ERROR] Command line was:............k-11/bin/javadoc @options
[ERROR]
[ERROR] Refer to the generated Javadoc files in
'i/bookkeeper-4.9.1/bookkeeper-stats/target/apidocs' dir.
[ERROR]
Il giorno gio 4 apr 2019 alle ore 22:17 Ivan Kelly <iv...@apache.org>
ha scritto:
>
> Sorry about the delay on getting to this, Enrico.
>
> +1 (binding)
>
> ✓ tag matches sha
> ✓ check sha512
> ✓ check gpg
> ✓ test licenses
> ✓ rat check
> ✓ compile -src
> ✓ spotbugs
> ✓ build tag
> ✓ compiled tag matches -src
> ✓ maven artifacts sigs are correct
> ✓ unit tests
> ✓ integration tests
>
> A few minor non-blocking things:
> - The tag isn't signed which may be a good thing to add to the process.
> - Building from -src, results in 2 maven artifacts that are not pushed to nexus,
> * ./org/apache/bookkeeper/bookkeeper-server/4.9.1/bookkeeper-server-4.9.1-javadoc.jar
> * ./org/apache/bookkeeper/stats/bookkeeper-stats-api/4.9.1/bookkeeper-stats-api-4.9.1-javadoc.jar
>
> -Ivan
Re: [VOTE] Release 4.9.1, release candidate #0
Posted by Ivan Kelly <iv...@apache.org>.
Sorry about the delay on getting to this, Enrico.
+1 (binding)
✓ tag matches sha
✓ check sha512
✓ check gpg
✓ test licenses
✓ rat check
✓ compile -src
✓ spotbugs
✓ build tag
✓ compiled tag matches -src
✓ maven artifacts sigs are correct
✓ unit tests
✓ integration tests
A few minor non-blocking things:
- The tag isn't signed which may be a good thing to add to the process.
- Building from -src, results in 2 maven artifacts that are not pushed to nexus,
* ./org/apache/bookkeeper/bookkeeper-server/4.9.1/bookkeeper-server-4.9.1-javadoc.jar
* ./org/apache/bookkeeper/stats/bookkeeper-stats-api/4.9.1/bookkeeper-stats-api-4.9.1-javadoc.jar
-Ivan
Re: [VOTE] Release 4.9.1, release candidate #0
Posted by Jia Zhai <zh...@gmail.com>.
+1 (binding)
Environment: macOS 10.14.2
- verified 4 packages checksum ( asc and sha all good)
- the source package build and test all run successfully.
- in both binary package(server & all), 'bin/bookkeeper standalone' and
'bin/bookkeeper shell bookiesanity' runs well.
Best Regards.
Jia Zhai
Beijing, China
Mobile: +86 15810491983
On Tue, Apr 2, 2019 at 5:50 AM Enrico Olivelli <eo...@gmail.com> wrote:
> Up
>
> Il mer 27 mar 2019, 15:14 Enrico Olivelli <eo...@gmail.com> ha
> scritto:
>
> > Please take a look
> >
> > Enrico
> >
> > Il gio 21 mar 2019, 23:43 Enrico Olivelli <eo...@apache.org> ha
> > scritto:
> >
> >> Hi everyone,
> >> Please review and vote on the release candidate #0 for the version
> >> 4.9.1, as follows:
> >> [ ] +1, Approve the release
> >> [ ] -1, Do not approve the release (please provide specific comments)
> >>
> >> The complete staging area is available for your review, which includes:
> >> * Release notes [1]
> >> * The official Apache source and binary distributions to be deployed
> >> to dist.apache.org [2]
> >> * All artifacts to be deployed to the Maven Central Repository [3]
> >> * Source code tag "v4.9.1-rc0" [4] with git sha
> >> c053b81be43845122a0627f12e1cf7e08330a3c5
> >>
> >> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> >> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> >>
> >> Please download these packages and review this release candidate:
> >>
> >> - Review release notes
> >> - Download the source package (verify shasum, and asc) and follow the
> >> instructions to build and run the bookkeeper service.
> >> - Download the binary package (verify shasum, and asc) and follow the
> >> instructions to run the bookkeeper service.
> >> - Review maven repo, release tag, licenses, and any other things you
> think
> >> it is important to a release.
> >>
> >> The vote will be open for at least 72 hours. It is adopted by majority
> >> approval, with at least 3 PMC affirmative votes.
> >>
> >> Thanks,
> >> Enrico Olivelli
> >>
> >> [1]
> >>
> https://github.com/apache/bookkeeper/pull/1992/commits/e24b8f98c0c435a0bba9dda0e4c37d9e88107187
> >> [2]
> >> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.9.1-rc0/
> >> [3]
> >>
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1040/
> >> [4] https://github.com/apache/bookkeeper/tree/v4.9.1-rc0
> >>
> >
>
Re: [VOTE] Release 4.9.1, release candidate #0
Posted by Enrico Olivelli <eo...@gmail.com>.
Up
Il mer 27 mar 2019, 15:14 Enrico Olivelli <eo...@gmail.com> ha scritto:
> Please take a look
>
> Enrico
>
> Il gio 21 mar 2019, 23:43 Enrico Olivelli <eo...@apache.org> ha
> scritto:
>
>> Hi everyone,
>> Please review and vote on the release candidate #0 for the version
>> 4.9.1, as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>> The complete staging area is available for your review, which includes:
>> * Release notes [1]
>> * The official Apache source and binary distributions to be deployed
>> to dist.apache.org [2]
>> * All artifacts to be deployed to the Maven Central Repository [3]
>> * Source code tag "v4.9.1-rc0" [4] with git sha
>> c053b81be43845122a0627f12e1cf7e08330a3c5
>>
>> BookKeeper's KEYS file contains PGP keys we used to sign this release:
>> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>>
>> Please download these packages and review this release candidate:
>>
>> - Review release notes
>> - Download the source package (verify shasum, and asc) and follow the
>> instructions to build and run the bookkeeper service.
>> - Download the binary package (verify shasum, and asc) and follow the
>> instructions to run the bookkeeper service.
>> - Review maven repo, release tag, licenses, and any other things you think
>> it is important to a release.
>>
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PMC affirmative votes.
>>
>> Thanks,
>> Enrico Olivelli
>>
>> [1]
>> https://github.com/apache/bookkeeper/pull/1992/commits/e24b8f98c0c435a0bba9dda0e4c37d9e88107187
>> [2]
>> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.9.1-rc0/
>> [3]
>> https://repository.apache.org/content/repositories/orgapachebookkeeper-1040/
>> [4] https://github.com/apache/bookkeeper/tree/v4.9.1-rc0
>>
>
Re: [VOTE] Release 4.9.1, release candidate #0
Posted by Enrico Olivelli <eo...@gmail.com>.
Please take a look
Enrico
Il gio 21 mar 2019, 23:43 Enrico Olivelli <eo...@apache.org> ha scritto:
> Hi everyone,
> Please review and vote on the release candidate #0 for the version
> 4.9.1, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * Release notes [1]
> * The official Apache source and binary distributions to be deployed
> to dist.apache.org [2]
> * All artifacts to be deployed to the Maven Central Repository [3]
> * Source code tag "v4.9.1-rc0" [4] with git sha
> c053b81be43845122a0627f12e1cf7e08330a3c5
>
> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>
> Please download these packages and review this release candidate:
>
> - Review release notes
> - Download the source package (verify shasum, and asc) and follow the
> instructions to build and run the bookkeeper service.
> - Download the binary package (verify shasum, and asc) and follow the
> instructions to run the bookkeeper service.
> - Review maven repo, release tag, licenses, and any other things you think
> it is important to a release.
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Enrico Olivelli
>
> [1]
> https://github.com/apache/bookkeeper/pull/1992/commits/e24b8f98c0c435a0bba9dda0e4c37d9e88107187
> [2]
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.9.1-rc0/
> [3]
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1040/
> [4] https://github.com/apache/bookkeeper/tree/v4.9.1-rc0
>